From e5db279eb80151413ff5b1c208838c7295e14651 Mon Sep 17 00:00:00 2001 From: fangyuedong Date: Wed, 29 May 2024 17:37:29 +0800 Subject: [PATCH 01/22] set t_exp to pointing.exp_time for shutter effect --- observation_sim/ObservationSim.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/observation_sim/ObservationSim.py b/observation_sim/ObservationSim.py index 051d6d1..1e82700 100755 --- a/observation_sim/ObservationSim.py +++ b/observation_sim/ObservationSim.py @@ -45,7 +45,7 @@ class Observation(object): chip.shutter_img = np.ones_like(chip.img.array) else: chip.shutter_img = effects.ShutterEffectArr( - chip.img, t_shutter=1.3, dist_bearing=735, dt=1E-3) + chip.img, t_exp=pointing.exp_time, t_shutter=1.3, dist_bearing=735, dt=1E-3) chip.prnu_img = effects.PRNU_Img(xsize=chip.npix_x, ysize=chip.npix_y, sigma=0.01, seed=int(self.config["random_seeds"]["seed_prnu"]+chip.chipID)) -- GitLab From 21c0174d9fa50784e801a0c3466cf4e1a6299366 Mon Sep 17 00:00:00 2001 From: fangyuedong Date: Wed, 29 May 2024 23:40:55 +0800 Subject: [PATCH 02/22] typo fix: in add_pattern_noise.py --- observation_sim/sim_steps/add_pattern_noise.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/observation_sim/sim_steps/add_pattern_noise.py b/observation_sim/sim_steps/add_pattern_noise.py index fc091c5..dfe90d0 100644 --- a/observation_sim/sim_steps/add_pattern_noise.py +++ b/observation_sim/sim_steps/add_pattern_noise.py @@ -81,5 +81,5 @@ def add_bias(self, chip, filt, tel, pointing, catalog, obs_param): nsecx=chip.nsecx, seed=self.overall_config["random_seeds"]["seed_biasNonUniform"]+chip.chipID) elif obs_param["bias_16channel"] == False: - chip.img += self.bias_level + chip.img += chip.bias_level return chip, filt, tel, pointing -- GitLab From 7bb9973280ddd9757695f5d234049e5833ef829b Mon Sep 17 00:00:00 2001 From: zhangxin Date: Mon, 10 Jun 2024 23:43:39 +0800 Subject: [PATCH 03/22] fix shutter effect bug --- observation_sim/instruments/chip/effects.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/observation_sim/instruments/chip/effects.py b/observation_sim/instruments/chip/effects.py index 7a6b7a6..21735ed 100644 --- a/observation_sim/instruments/chip/effects.py +++ b/observation_sim/instruments/chip/effects.py @@ -793,7 +793,7 @@ def ShutterEffectArr(GSImage, t_exp=150, t_shutter=1.3, dist_bearing=735, dt=1E- sizey = ymax-ymin+1 xnewgrid = np.mgrid[xmin:(xmin+sizex)] expeffect = interpolate.splev(xnewgrid, intp, der=0) - expeffect /= np.max(expeffect) + expeffect /= t_exp exparrnormal = np.tile(expeffect, (sizey,1)) # GSImage *= exparrnormal -- GitLab From e1a6d2415558ad6d3f4a268fc974c44e41c03a2f Mon Sep 17 00:00:00 2001 From: zhangxin Date: Thu, 13 Jun 2024 12:45:19 +0800 Subject: [PATCH 04/22] modify getWCS in Tools --- tools/get_pointing.py | 22 +++++++++++++--------- tools/target_location_check.py | 9 +++++++-- 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/tools/get_pointing.py b/tools/get_pointing.py index 073d160..39216a1 100755 --- a/tools/get_pointing.py +++ b/tools/get_pointing.py @@ -63,10 +63,15 @@ class Chip(object): ycen = self.cen_pix_y if pix_scale == None: pix_scale = self.pix_scale - dudx = -np.cos(img_rot.rad) * pix_scale - dudy = -np.sin(img_rot.rad) * pix_scale - dvdx = -np.sin(img_rot.rad) * pix_scale - dvdy = +np.cos(img_rot.rad) * pix_scale + # dudx = -np.cos(img_rot.rad) * pix_scale + # dudy = -np.sin(img_rot.rad) * pix_scale + # dvdx = -np.sin(img_rot.rad) * pix_scale + # dvdy = +np.cos(img_rot.rad) * pix_scale + + dudx = -np.cos(img_rot.rad) * pix_scale + dudy = +np.sin(img_rot.rad) * pix_scale + dvdx = -np.sin(img_rot.rad) * pix_scale + dvdy = -np.cos(img_rot.rad) * pix_scale # dudx = +np.sin(img_rot.rad) * pix_scale # dudy = +np.cos(img_rot.rad) * pix_scale @@ -139,12 +144,11 @@ def getobsPA(ra, dec): angle = math.acos(np.dot(l1l2cross,pdl2cross)/(np.linalg.norm(l1l2cross)*np.linalg.norm(pdl2cross))) angle = (angle)/math.pi*180 - - # if (ra>90 and ra< 270): - # angle=-angle + angle = angle + 90 + if (ra<90 or ra> 270): + angle=-angle return angle - # @jit() def getSelectPointingList(center = [60,-40], radius = 2): points = np.loadtxt('sky.dat') @@ -261,7 +265,7 @@ def findPointingbyChipID(chipID = 8, ra = 60., dec = -40.): if __name__ == "__main__": - tchip, tra, tdec = 8, 60., -40. + tchip, tra, tdec = 13, 60., -40. pointing = findPointingbyChipID(chipID=tchip, ra=tra, dec=tdec) print("[ra_center, dec_center, image_rot]: ", pointing) diff --git a/tools/target_location_check.py b/tools/target_location_check.py index 34293be..11f22ba 100644 --- a/tools/target_location_check.py +++ b/tools/target_location_check.py @@ -119,10 +119,15 @@ def getTanWCS(ra, dec, img_rot, pix_scale=0.074): """ xcen, ycen = 0, 0 img_rot = img_rot * galsim.degrees + # dudx = -np.cos(img_rot.rad) * pix_scale + # dudy = -np.sin(img_rot.rad) * pix_scale + # dvdx = -np.sin(img_rot.rad) * pix_scale + # dvdy = +np.cos(img_rot.rad) * pix_scale + dudx = -np.cos(img_rot.rad) * pix_scale - dudy = -np.sin(img_rot.rad) * pix_scale + dudy = +np.sin(img_rot.rad) * pix_scale dvdx = -np.sin(img_rot.rad) * pix_scale - dvdy = +np.cos(img_rot.rad) * pix_scale + dvdy = -np.cos(img_rot.rad) * pix_scale moscen = galsim.PositionD(x=xcen, y=ycen) sky_center = galsim.CelestialCoord( -- GitLab From 4f8ea7d136070de186babdec00955f26420b2d51 Mon Sep 17 00:00:00 2001 From: zhangxin Date: Mon, 17 Jun 2024 14:22:07 +0800 Subject: [PATCH 05/22] fix issue43:FILENAME keywords cut by len 80 --- observation_sim/sim_steps/readout_output.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/observation_sim/sim_steps/readout_output.py b/observation_sim/sim_steps/readout_output.py index 8ef872f..c2cb8a1 100644 --- a/observation_sim/sim_steps/readout_output.py +++ b/observation_sim/sim_steps/readout_output.py @@ -86,10 +86,10 @@ def quantization_and_output(self, chip, filt, tel, pointing, catalog, obs_param) fname = os.path.join(self.chip_output.subdir, self.h_prim['FILENAME'] + '.fits') - f_name_size = 68 - if (len(self.h_prim['FILENAME']) > f_name_size): - self.updateHeaderInfo(header_flag='prim', keys=['FILENAME'], values=[ - self.h_prim['FILENAME'][0:f_name_size]]) + # f_name_size = 68 + # if (len(self.h_prim['FILENAME']) > f_name_size): + # self.updateHeaderInfo(header_flag='prim', keys=['FILENAME'], values=[ + # self.h_prim['FILENAME'][0:f_name_size]]) hdu1 = fits.PrimaryHDU(header=self.h_prim) -- GitLab From df15b1ac40365fbff47d49659b1750363ec82d72 Mon Sep 17 00:00:00 2001 From: zhangxin Date: Mon, 17 Jun 2024 14:36:25 +0800 Subject: [PATCH 06/22] modify sls convolve psf method --- observation_sim/ObservationSim.py | 27 +++- observation_sim/mock_objects/MockObject.py | 150 +++++++++++++-------- observation_sim/psf/PSFInterpSLS.py | 106 ++++++++++++++- observation_sim/sim_steps/add_objects.py | 22 +++ 4 files changed, 245 insertions(+), 60 deletions(-) diff --git a/observation_sim/ObservationSim.py b/observation_sim/ObservationSim.py index 1e82700..2550c06 100755 --- a/observation_sim/ObservationSim.py +++ b/observation_sim/ObservationSim.py @@ -23,7 +23,7 @@ class Observation(object): self.filter_param = FilterParam() self.Catalog = Catalog - def prepare_chip_for_exposure(self, chip, ra_cen, dec_cen, pointing, wcs_fp=None): + def prepare_chip_for_exposure(self, chip, ra_cen, dec_cen, pointing, wcs_fp=None, slsPSFOptim = False): # Get WCS for the focal plane if wcs_fp == None: wcs_fp = self.focal_plane.getTanWCS( @@ -34,6 +34,26 @@ class Observation(object): chip.img.setOrigin(chip.bound.xmin, chip.bound.ymin) chip.img.wcs = wcs_fp + chip.slsPSFOptim = slsPSFOptim + if chip.chipID in [1,2,3,4,5,10,21,26,27,28,29,30] and slsPSFOptim: + chip.img_stack = {} + for id1 in np.arange(2): + gn = chip_utils.getChipSLSGratingID(chip.chipID)[id1] + orders = {} + # for id2 in ['-2','-1','0','1','2']: + for id2 in ['0','1']: + o_n = "order"+id2 + allbands = {} + for id3 in ['1','2','3','4']: + w_n = "w"+id3 + allbands[w_n] = galsim.ImageF(chip.npix_x, chip.npix_y) + allbands[w_n].setOrigin(chip.bound.xmin, chip.bound.ymin) + allbands[w_n].wcs = wcs_fp + orders[o_n] = allbands + chip.img_stack[gn] = orders + else: + chip.img_stack = {} + # Get random generators for this chip chip.rng_poisson, chip.poisson_noise = chip_utils.get_poisson( seed=int(self.config["random_seeds"]["seed_poisson"]) + pointing.id*30 + chip.chipID, sky_level=0.) @@ -95,9 +115,10 @@ class Observation(object): else: ra_cen = pointing.ra dec_cen = pointing.dec - + + slsPSFOpt = True # Prepare necessary chip properties for simulation - chip = self.prepare_chip_for_exposure(chip, ra_cen, dec_cen, pointing) + chip = self.prepare_chip_for_exposure(chip, ra_cen, dec_cen, pointing, slsPSFOptim = slsPSFOpt) # Initialize SimSteps sim_steps = SimSteps(overall_config=self.config, diff --git a/observation_sim/mock_objects/MockObject.py b/observation_sim/mock_objects/MockObject.py index 12e3612..632bd9e 100755 --- a/observation_sim/mock_objects/MockObject.py +++ b/observation_sim/mock_objects/MockObject.py @@ -11,6 +11,8 @@ from observation_sim.mock_objects._util import integrate_sed_bandpass, getNormFa getABMAG from observation_sim.mock_objects.SpecDisperser import SpecDisperser +from observation_sim.instruments.chip import chip_utils + class MockObject(object): def __init__(self, param, logger=None): @@ -239,63 +241,101 @@ class MockObject(object): def addSLStoChipImageWithPSF(self, sdp=None, chip=None, pos_img_local=[1, 1], psf_model=None, bandNo=1, grating_split_pos=3685, local_wcs=None, pos_img=None): spec_orders = sdp.compute_spec_orders() - for k, v in spec_orders.items(): - img_s = v[0] - # print(bandNo,k) - try: - psf, pos_shear = psf_model.get_PSF( - chip, pos_img_local=pos_img_local, bandNo=bandNo, galsimGSObject=True, g_order=k, grating_split_pos=grating_split_pos) - except: - psf, pos_shear = psf_model.get_PSF(chip=chip, pos_img=pos_img) - psf_img = psf.drawImage(nx=100, ny=100, wcs=local_wcs) + if chip.slsPSFOptim: + for k, v in spec_orders.items(): + img_s = v[0] + pos_shear = galsim.Shear(e=0., beta=(np.pi/2)*galsim.radians) + + nan_ids = np.isnan(img_s) + if img_s[nan_ids].shape[0] > 0: + img_s[nan_ids] = 0 + print("DEBUG: specImg nan num is", img_s[nan_ids].shape[0]) + ######################################################### + # img_s, orig_off = convolveImg(img_s, psf_img_m) + orig_off = [0,0] + origin_order_x = v[1] - orig_off[0] + origin_order_y = v[2] - orig_off[1] + + specImg = galsim.ImageF(img_s) + + specImg.wcs = local_wcs + specImg.setOrigin(origin_order_x, origin_order_y) + + bounds = specImg.bounds & galsim.BoundsI( + 0, chip.npix_x - 1, 0, chip.npix_y - 1) + if bounds.area() == 0: + continue + + # orders = {'A': 'order1', 'B': 'order0', 'C': 'order2', 'D': 'order-1', 'E': 'order-2'} + orders = {'A': 'order1', 'B': 'order0', 'C': 'order0', 'D': 'order0', 'E': 'order0'} + gratingN = chip_utils.getChipSLSGratingID(chip.chipID)[1] + if pos_img_local[0] < grating_split_pos: + gratingN = chip_utils.getChipSLSGratingID(chip.chipID)[0] + + + chip.img_stack[gratingN][orders[k]]['w' + str(bandNo)].setOrigin(0, 0) + chip.img_stack[gratingN][orders[k]]['w' + str(bandNo)][bounds] = chip.img_stack[gratingN][orders[k]]['w' + str(bandNo)][bounds] + specImg[bounds] + chip.img_stack[gratingN][orders[k]]['w' + str(bandNo)].setOrigin(chip.bound.xmin, chip.bound.ymin) - psf_img_m = psf_img.array - - ######################################################### - # DEBUG - ######################################################### - # ids_p = psf_img_m < 0 - # psf_img_m[ids_p] = 0 - - # from astropy.io import fits - # fits.writeto(str(bandNo) + '_' + str(k) + '_psf.fits', psf_img_m) - - # print("DEBUG: orig_off is", orig_off) - nan_ids = np.isnan(img_s) - if img_s[nan_ids].shape[0] > 0: - img_s[nan_ids] = 0 - print("DEBUG: specImg nan num is", img_s[nan_ids].shape[0]) - ######################################################### - img_s, orig_off = convolveImg(img_s, psf_img_m) - origin_order_x = v[1] - orig_off[0] - origin_order_y = v[2] - orig_off[1] - - specImg = galsim.ImageF(img_s) - # photons = galsim.PhotonArray.makeFromImage(specImg) - # photons.x += origin_order_x - # photons.y += origin_order_y - - # xlen_imf = int(specImg.xmax - specImg.xmin + 1) - # ylen_imf = int(specImg.ymax - specImg.ymin + 1) - # stamp = galsim.ImageF(xlen_imf, ylen_imf) - # stamp.wcs = local_wcs - # stamp.setOrigin(origin_order_x, origin_order_y) - - specImg.wcs = local_wcs - specImg.setOrigin(origin_order_x, origin_order_y) - - bounds = specImg.bounds & galsim.BoundsI( - 0, chip.npix_x - 1, 0, chip.npix_y - 1) - if bounds.area() == 0: - continue - chip.img.setOrigin(0, 0) - chip.img[bounds] = chip.img[bounds] + specImg[bounds] - # stamp[bounds] = chip.img[bounds] - # # chip.sensor.accumulate(photons, stamp) - # chip.img[bounds] = stamp[bounds] - chip.img.setOrigin(chip.bound.xmin, chip.bound.ymin) - # del stamp + else: + for k, v in spec_orders.items(): + img_s = v[0] + # print(bandNo,k) + try: + psf, pos_shear = psf_model.get_PSF( + chip, pos_img_local=pos_img_local, bandNo=bandNo, galsimGSObject=True, g_order=k, grating_split_pos=grating_split_pos) + except: + psf, pos_shear = psf_model.get_PSF(chip=chip, pos_img=pos_img) + + psf_img = psf.drawImage(nx=100, ny=100, wcs=local_wcs) + + psf_img_m = psf_img.array + + ######################################################### + # DEBUG + ######################################################### + # ids_p = psf_img_m < 0 + # psf_img_m[ids_p] = 0 + + # from astropy.io import fits + # fits.writeto(str(bandNo) + '_' + str(k) + '_psf.fits', psf_img_m) + + # print("DEBUG: orig_off is", orig_off) + nan_ids = np.isnan(img_s) + if img_s[nan_ids].shape[0] > 0: + img_s[nan_ids] = 0 + print("DEBUG: specImg nan num is", img_s[nan_ids].shape[0]) + ######################################################### + img_s, orig_off = convolveImg(img_s, psf_img_m) + origin_order_x = v[1] - orig_off[0] + origin_order_y = v[2] - orig_off[1] + + specImg = galsim.ImageF(img_s) + # photons = galsim.PhotonArray.makeFromImage(specImg) + # photons.x += origin_order_x + # photons.y += origin_order_y + + # xlen_imf = int(specImg.xmax - specImg.xmin + 1) + # ylen_imf = int(specImg.ymax - specImg.ymin + 1) + # stamp = galsim.ImageF(xlen_imf, ylen_imf) + # stamp.wcs = local_wcs + # stamp.setOrigin(origin_order_x, origin_order_y) + + specImg.wcs = local_wcs + specImg.setOrigin(origin_order_x, origin_order_y) + + bounds = specImg.bounds & galsim.BoundsI( + 0, chip.npix_x - 1, 0, chip.npix_y - 1) + if bounds.area() == 0: + continue + chip.img.setOrigin(0, 0) + chip.img[bounds] = chip.img[bounds] + specImg[bounds] + # stamp[bounds] = chip.img[bounds] + # # chip.sensor.accumulate(photons, stamp) + # chip.img[bounds] = stamp[bounds] + chip.img.setOrigin(chip.bound.xmin, chip.bound.ymin) + # del stamp del spec_orders return pos_shear diff --git a/observation_sim/psf/PSFInterpSLS.py b/observation_sim/psf/PSFInterpSLS.py index 7adfedc..673a69b 100644 --- a/observation_sim/psf/PSFInterpSLS.py +++ b/observation_sim/psf/PSFInterpSLS.py @@ -20,8 +20,10 @@ import os from astropy.io import fits from astropy.modeling.models import Gaussian2D -from scipy import signal - +from scipy import signal, interpolate +import datetime +import gc +from jax import numpy as jnp LOG_DEBUG = False # ***# NPSF = 900 # ***# 30*30 @@ -479,6 +481,106 @@ class PSFInterpSLS(PSFModel): return PSF_int_trans, PSF_int + def convolveFullImgWithPCAPSF(self, chip, folding_threshold=5.e-3): + keys_L1= chip_utils.getChipSLSGratingID(chip.chipID) + # keys_L2 = ['order-2','order-1','order0','order1','order2'] + keys_L2 = ['order0','order1'] + keys_L3 = ['w1','w2','w3','w4'] + + npca = 10 + + x_start = chip.x_cen/chip.pix_size - chip.npix_x / 2. + y_start = chip.y_cen/chip.pix_size - chip.npix_y / 2. + + for i,gt in enumerate(keys_L1): + psfCo = self.grating1_data + if i > 0: + psfCo = self.grating2_data + for od in keys_L2: + psfCo_L2 = psfCo['order1'] + if od in ['order-2','order-1','order0','order2']: + psfCo_L2 = psfCo['order0'] + for w in keys_L3: + img = chip.img_stack[gt][od][w] + pcs = psfCo_L2['band'+w[1]]['band_data'][0].data + pos_p = psfCo_L2['band'+w[1]]['band_data'][1].data/chip.pix_size - np.array([y_start, x_start]) + pc_coeff = psfCo_L2['band'+w[1]]['band_data'][2].data + # print("DEBUG-----------",np.max(pos_p[:,1]),np.min(pos_p[:,1]), np.max(pos_p[:,0]),np.min(pos_p[:,0])) + sum_img = np.sum(img.array) + + + # coeff_mat = np.zeros([npca, chip.npix_y, chip.npix_x]) + # for m in np.arange(chip.npix_y): + # for n in np.arange(chip.npix_x): + # px = n + # py = m + + # dist2 = (pos_p[:, 1] - px)*(pos_p[:, 1] - px) + (pos_p[:, 0] - py)*(pos_p[:, 0] - py) + # temp_sort_dist = np.zeros([dist2.shape[0], 2]) + # temp_sort_dist[:, 0] = np.arange(0, dist2.shape[0], 1) + # temp_sort_dist[:, 1] = dist2 + # # print(temp_sort_dist) + # dits2_sortlist = sorted(temp_sort_dist, key=lambda x: x[1]) + # # print(dits2_sortlist) + # nearest4p = np.zeros([4, 3]) + # pc_coeff_4p = np.zeros([npca, 4]) + + # for i in np.arange(4): + # smaller_ids = int(dits2_sortlist[i][0]) + # nearest4p[i, 0] = pos_p[smaller_ids, 1] + # nearest4p[i, 1] = pos_p[smaller_ids, 0] + # # print(pos_p[smaller_ids, 1],pos_p[smaller_ids, 0]) + # nearest4p[i, 2] = dits2_sortlist[i][1] + # pc_coeff_4p[:, i] = pc_coeff[npca, smaller_ids] + # # idw_dist = 1/(np.sqrt((px-nearest4p[:, 0]) * (px-nearest4p[:, 0]) + ( + # # py-nearest4p[:, 1]) * (py-nearest4p[:, 1]))) + # idw_dist = 1/(np.sqrt(nearest4p[:, 2])) + + # coeff_int = np.zeros(npca) + # for i in np.arange(4): + # coeff_int = coeff_int + pc_coeff_4p[:, i]*idw_dist[i] + # coeff_mat[:, m, n] = coeff_int + + m_size = int(pcs.shape[0]**0.5) + tmp_img = np.zeros_like(img.array,dtype=np.float32) + for j in np.arange(npca): + print(gt, od, w, j) + X_ = jnp.hstack((pos_p[:,1].flatten()[:, None], pos_p[:,0].flatten()[:, None]),dtype=np.float32) + Z_ = (pc_coeff[j].astype(np.float32)).flatten() + # print(pc_coeff[j].shape[0], pos_p[:,1].shape[0], pos_p[:,0].shape[0]) + sub_size = 4 + cx_len = int(chip.npix_x/sub_size) + cy_len = int(chip.npix_y/sub_size) + n_x = jnp.arange(0, cx_len, 1, dtype = int) + n_y = jnp.arange(0, cy_len, 1, dtype = int) + + M, N = jnp.meshgrid(n_x, n_y) + t1=datetime.datetime.now() + # U = interpolate.griddata(X_, Z_, (M[0:cy_len, 0:cx_len],N[0:cy_len, 0:cx_len]), + # method='nearest',fill_value=1.0) + U1 = interpolate.griddata(X_, Z_, (M[0:cy_len, 0:cx_len],N[0:cy_len, 0:cx_len]), + method='nearest',fill_value=1.0) + U = np.zeros_like(chip.img.array, dtype=np.float32) + for mi in np.arange(cx_len): + for mj in np.arange(cx_len): + U[mi*sub_size:(mi+1)*sub_size, mj*sub_size:(mj+1)*sub_size]=U1[mi,mj] + t2=datetime.datetime.now() + + print("time interpolate:", t2-t1) + + img_tmp = img.array*U + psf = pcs[:, j].reshape(m_size, m_size) + tmp_img = tmp_img + signal.fftconvolve(img_tmp, psf, mode='same', axes=None) + + t3=datetime.datetime.now() + print("time convole:", t3-t2) + del U + del U1 + + chip.img = chip.img + tmp_img*sum_img/np.sum(tmp_img) + del tmp_img + gc.collect() + # pixSize = np.rad2deg(self.pixsize*1e-3/28)*3600 #set psf pixsize # # # assert self.iccd == int(chip.getChipLabel(chipID=chip.chipID)), 'ERROR: self.iccd != chip.chipID' diff --git a/observation_sim/sim_steps/add_objects.py b/observation_sim/sim_steps/add_objects.py index 9f41d36..9f4c109 100644 --- a/observation_sim/sim_steps/add_objects.py +++ b/observation_sim/sim_steps/add_objects.py @@ -217,6 +217,28 @@ def add_objects(self, chip, filt, tel, pointing, catalog, obs_param): obj.unload_SED() del obj gc.collect() + + if chip.survey_type == "spectroscopic" and not self.overall_config["run_option"]["out_cat_only"] and chip.slsPSFOptim: + # from observation_sim.instruments.chip import chip_utils as chip_utils + # gn = chip_utils.getChipSLSGratingID(chip.chipID)[0] + # img1 = np.zeros([2,chip.img.array.shape[0],chip.img.array.shape[1]]) + + # for id1 in np.arange(2): + # gn = chip_utils.getChipSLSGratingID(chip.chipID)[id1] + # img_i = 0 + # for id2 in ['0','1']: + # o_n = "order"+id2 + # for id3 in ['1','2','3','4']: + # w_n = "w"+id3 + # img1[img_i] = img1[img_i] + chip.img_stack[gn][o_n][w_n].array + # img_i = img_i + 1 + # from astropy.io import fits + # fits.writeto('order0.fits',img1[0],overwrite=True) + # fits.writeto('order1.fits',img1[1],overwrite=True) + + psf_model.convolveFullImgWithPCAPSF(chip) + + del psf_model gc.collect() -- GitLab From 18700088479fce01f12e02dc1a9301e8fa63616d Mon Sep 17 00:00:00 2001 From: zhangxin Date: Fri, 21 Jun 2024 10:09:31 +0800 Subject: [PATCH 07/22] add new psf convolve for single source; fix header bug --- observation_sim/config/header/ImageHeader.py | 2 +- observation_sim/mock_objects/MockObject.py | 107 ++++++++++++------- observation_sim/psf/PSFInterpSLS.py | 93 ++++++++++++++++ 3 files changed, 163 insertions(+), 39 deletions(-) diff --git a/observation_sim/config/header/ImageHeader.py b/observation_sim/config/header/ImageHeader.py index 7fc3444..25a2867 100644 --- a/observation_sim/config/header/ImageHeader.py +++ b/observation_sim/config/header/ImageHeader.py @@ -434,7 +434,7 @@ def generatePrimaryHeader(xlen=9216, ylen=9232, pointing_id='00000001', pointing co = coord.SkyCoord(ra, dec, unit='deg') ra_hms = format(co.ra.hms.h, '02.0f') + format(co.ra.hms.m, - '02.0f') + format(co.ra.hms.s, '02.1f') + '02.0f') + format(co.ra.hms.s, '04.1f') dec_hms = format(co.dec.dms.d, '02.0f') + format(abs(co.dec.dms.m), '02.0f') + format(abs(co.dec.dms.s), '02.0f') if dec >= 0: diff --git a/observation_sim/mock_objects/MockObject.py b/observation_sim/mock_objects/MockObject.py index 632bd9e..0797ea6 100755 --- a/observation_sim/mock_objects/MockObject.py +++ b/observation_sim/mock_objects/MockObject.py @@ -120,7 +120,6 @@ class MockObject(object): if self.logger: self.logger.error(e) return 2, None - # Set Galsim Parameters if self.getMagFilter(filt) <= 15: folding_threshold = 5.e-4 @@ -241,12 +240,11 @@ class MockObject(object): def addSLStoChipImageWithPSF(self, sdp=None, chip=None, pos_img_local=[1, 1], psf_model=None, bandNo=1, grating_split_pos=3685, local_wcs=None, pos_img=None): spec_orders = sdp.compute_spec_orders() - + pos_shear = galsim.Shear(e=0., beta=(np.pi/2)*galsim.radians) if chip.slsPSFOptim: for k, v in spec_orders.items(): img_s = v[0] - pos_shear = galsim.Shear(e=0., beta=(np.pi/2)*galsim.radians) - + nan_ids = np.isnan(img_s) if img_s[nan_ids].shape[0] > 0: img_s[nan_ids] = 0 @@ -280,50 +278,83 @@ class MockObject(object): else: for k, v in spec_orders.items(): + # img_s = v[0] + # # print(bandNo,k) + # try: + # psf, pos_shear = psf_model.get_PSF( + # chip, pos_img_local=pos_img_local, bandNo=bandNo, galsimGSObject=True, g_order=k, grating_split_pos=grating_split_pos) + # except: + # psf, pos_shear = psf_model.get_PSF(chip=chip, pos_img=pos_img) + + # psf_img = psf.drawImage(nx=100, ny=100, wcs=local_wcs) + + # psf_img_m = psf_img.array + + # ######################################################### + # # DEBUG + # ######################################################### + # # ids_p = psf_img_m < 0 + # # psf_img_m[ids_p] = 0 + + # # from astropy.io import fits + # # fits.writeto(str(bandNo) + '_' + str(k) + '_psf.fits', psf_img_m) + + # # print("DEBUG: orig_off is", orig_off) + # nan_ids = np.isnan(img_s) + # if img_s[nan_ids].shape[0] > 0: + # img_s[nan_ids] = 0 + # print("DEBUG: specImg nan num is", img_s[nan_ids].shape[0]) + # ######################################################### + # img_s, orig_off = convolveImg(img_s, psf_img_m) + # origin_order_x = v[1] - orig_off[0] + # origin_order_y = v[2] - orig_off[1] + + # specImg = galsim.ImageF(img_s) + # # photons = galsim.PhotonArray.makeFromImage(specImg) + # # photons.x += origin_order_x + # # photons.y += origin_order_y + + # # xlen_imf = int(specImg.xmax - specImg.xmin + 1) + # # ylen_imf = int(specImg.ymax - specImg.ymin + 1) + # # stamp = galsim.ImageF(xlen_imf, ylen_imf) + # # stamp.wcs = local_wcs + # # stamp.setOrigin(origin_order_x, origin_order_y) + + # specImg.wcs = local_wcs + # specImg.setOrigin(origin_order_x, origin_order_y) + + print('DEBUG: BEGIN -----------',bandNo,k) + img_s = v[0] - # print(bandNo,k) - try: - psf, pos_shear = psf_model.get_PSF( - chip, pos_img_local=pos_img_local, bandNo=bandNo, galsimGSObject=True, g_order=k, grating_split_pos=grating_split_pos) - except: - psf, pos_shear = psf_model.get_PSF(chip=chip, pos_img=pos_img) - - psf_img = psf.drawImage(nx=100, ny=100, wcs=local_wcs) - - psf_img_m = psf_img.array - - ######################################################### - # DEBUG - ######################################################### - # ids_p = psf_img_m < 0 - # psf_img_m[ids_p] = 0 - - # from astropy.io import fits - # fits.writeto(str(bandNo) + '_' + str(k) + '_psf.fits', psf_img_m) - - # print("DEBUG: orig_off is", orig_off) + nan_ids = np.isnan(img_s) if img_s[nan_ids].shape[0] > 0: img_s[nan_ids] = 0 print("DEBUG: specImg nan num is", img_s[nan_ids].shape[0]) ######################################################### - img_s, orig_off = convolveImg(img_s, psf_img_m) - origin_order_x = v[1] - orig_off[0] - origin_order_y = v[2] - orig_off[1] - + origin_order_x = v[1] + origin_order_y = v[2] specImg = galsim.ImageF(img_s) - # photons = galsim.PhotonArray.makeFromImage(specImg) - # photons.x += origin_order_x - # photons.y += origin_order_y - - # xlen_imf = int(specImg.xmax - specImg.xmin + 1) - # ylen_imf = int(specImg.ymax - specImg.ymin + 1) - # stamp = galsim.ImageF(xlen_imf, ylen_imf) - # stamp.wcs = local_wcs - # stamp.setOrigin(origin_order_x, origin_order_y) specImg.wcs = local_wcs specImg.setOrigin(origin_order_x, origin_order_y) + try: + specImg = psf_model.get_PSF_AND_convolve_withsubImg(chip, cutImg=specImg, bandNo=bandNo, g_order=k, grating_split_pos=grating_split_pos) + except: + psf, pos_shear = psf_model.get_PSF(chip=chip, pos_img=pos_img) + + psf_img = psf.drawImage(nx=100, ny=100, wcs=local_wcs) + + psf_img_m = psf_img.array + + img_s, orig_off = convolveImg(img_s, psf_img_m) + origin_order_x = v[1] - orig_off[0] + origin_order_y = v[2] - orig_off[1] + + specImg = galsim.ImageF(img_s) + + specImg.wcs = local_wcs + specImg.setOrigin(origin_order_x, origin_order_y) bounds = specImg.bounds & galsim.BoundsI( 0, chip.npix_x - 1, 0, chip.npix_y - 1) diff --git a/observation_sim/psf/PSFInterpSLS.py b/observation_sim/psf/PSFInterpSLS.py index 673a69b..0b534e2 100644 --- a/observation_sim/psf/PSFInterpSLS.py +++ b/observation_sim/psf/PSFInterpSLS.py @@ -481,6 +481,99 @@ class PSFInterpSLS(PSFModel): return PSF_int_trans, PSF_int + def get_PSF_AND_convolve_withsubImg(self, chip, cutImg=None, bandNo=1, g_order='A', grating_split_pos=3685): + """ + Get the PSF at a given image position + + Parameters: + chip: A 'Chip' object representing the chip we want to extract PSF from. + pos_img: A 'galsim.Position' object representing the image position. + bandpass: A 'galsim.Bandpass' object representing the wavelength range. + pixSize: The pixels size of psf matrix + findNeighMode: 'treeFind' or 'hoclistFind' + Returns: + PSF: A 'galsim.GSObject'. + """ + order_IDs = {'A': '1', 'B': '0', 'C': '0', 'D': '0', 'E': '0'} + contam_order_sigma = {'C': 0.28032344707964174, + 'D': 0.39900182912061344, 'E': 1.1988309797685412} # arcsec + x_start = chip.x_cen/chip.pix_size - chip.npix_x / 2. + y_start = chip.y_cen/chip.pix_size - chip.npix_y / 2. + # print(pos_img.x - x_start) + # pos_img_x = pos_img_local[0] + x_start + # pos_img_y = pos_img_local[1] + y_start + # pos_img = galsim.PositionD(pos_img_x, pos_img_y) + centerPos_local = cutImg.ncol/2. + if centerPos_local < grating_split_pos: + psf_data = self.grating1_data + else: + psf_data = self.grating2_data + + grating_order = order_IDs[g_order] + # if grating_order in ['-2','-1','2']: + # grating_order = '1' + + # if grating_order in ['0', '1']: + psf_order = psf_data['order'+grating_order] + psf_order_b = psf_order['band'+str(bandNo)] + psf_b_dat = psf_order_b['band_data'] + # pos_p = psf_b_dat[1].data + pos_p = psf_b_dat[1].data/chip.pix_size - np.array([y_start, x_start]) + + pc_coeff = psf_b_dat[2].data + pcs = psf_b_dat[0].data + + npc = 10 + m_size = int(pcs.shape[0]**0.5) + tmp_img = cutImg*0 + for j in np.arange(npc): + X_ = jnp.hstack((pos_p[:,1].flatten()[:, None], pos_p[:,0].flatten()[:, None]),dtype=np.float32) + Z_ = (pc_coeff[j].astype(np.float32)).flatten() + # print(pc_coeff[j].shape[0], pos_p[:,1].shape[0], pos_p[:,0].shape[0]) + cx_len = int(chip.npix_x) + cy_len = int(chip.npix_y) + n_x = jnp.arange(0, cx_len, 1, dtype = int) + n_y = jnp.arange(0, cy_len, 1, dtype = int) + + M, N = jnp.meshgrid(n_x, n_y) + t1=datetime.datetime.now() + # U = interpolate.griddata(X_, Z_, (M[0:cy_len, 0:cx_len],N[0:cy_len, 0:cx_len]), + # method='nearest',fill_value=1.0) + ys = cutImg.ymin + if ys < 0: + ys = 0 + ye = cutImg.ymin+cutImg.nrow + if ye >= cy_len-1: + ye = cy_len-1 + if ye - ys <=0: + continue + xs = cutImg.xmin + if xs < 0: + xs = 0 + xe = cutImg.xmin+cutImg.ncol + if xe >= cx_len-1: + xe = cx_len-1 + if xe - xs <=0: + continue + U = interpolate.griddata(X_, Z_, (M[ys:ye, xs:xe],N[ys:ye, xs:xe]), + method='nearest',fill_value=1.0) + t2=datetime.datetime.now() + + print("time interpolate:", t2-t1) + + if U.shape != cutImg.array.shape: + print('DEBUG:SHAPE',cutImg.ncol,cutImg.nrow,cutImg.xmin, cutImg.ymin) + continue + img_tmp = cutImg.array*U + psf = pcs[:, j].reshape(m_size, m_size) + tmp_img = tmp_img + signal.fftconvolve(img_tmp, psf, mode='same', axes=None) + + t3=datetime.datetime.now() + print("time convole:", t3-t2) + del U + return tmp_img + + def convolveFullImgWithPCAPSF(self, chip, folding_threshold=5.e-3): keys_L1= chip_utils.getChipSLSGratingID(chip.chipID) # keys_L2 = ['order-2','order-1','order0','order1','order2'] -- GitLab From 5972feeb6d70ca570a77ef555408773b59954df9 Mon Sep 17 00:00:00 2001 From: zhangxin Date: Fri, 21 Jun 2024 10:28:32 +0800 Subject: [PATCH 08/22] fig ISSUE48: TARGET seg error --- observation_sim/config/header/ImageHeader.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/observation_sim/config/header/ImageHeader.py b/observation_sim/config/header/ImageHeader.py index 7fc3444..25a2867 100644 --- a/observation_sim/config/header/ImageHeader.py +++ b/observation_sim/config/header/ImageHeader.py @@ -434,7 +434,7 @@ def generatePrimaryHeader(xlen=9216, ylen=9232, pointing_id='00000001', pointing co = coord.SkyCoord(ra, dec, unit='deg') ra_hms = format(co.ra.hms.h, '02.0f') + format(co.ra.hms.m, - '02.0f') + format(co.ra.hms.s, '02.1f') + '02.0f') + format(co.ra.hms.s, '04.1f') dec_hms = format(co.dec.dms.d, '02.0f') + format(abs(co.dec.dms.m), '02.0f') + format(abs(co.dec.dms.s), '02.0f') if dec >= 0: -- GitLab From 45494b69d8aa2439d25c19e92d94b9fc89a768ad Mon Sep 17 00:00:00 2001 From: zhangxin Date: Tue, 2 Jul 2024 15:13:52 +0800 Subject: [PATCH 09/22] fix position bug --- observation_sim/mock_objects/MockObject.py | 4 +- observation_sim/psf/PSFInterpSLS.py | 82 +++++++++++++--------- 2 files changed, 51 insertions(+), 35 deletions(-) diff --git a/observation_sim/mock_objects/MockObject.py b/observation_sim/mock_objects/MockObject.py index 0797ea6..5927d95 100755 --- a/observation_sim/mock_objects/MockObject.py +++ b/observation_sim/mock_objects/MockObject.py @@ -323,7 +323,7 @@ class MockObject(object): # specImg.wcs = local_wcs # specImg.setOrigin(origin_order_x, origin_order_y) - print('DEBUG: BEGIN -----------',bandNo,k) + # print('DEBUG: BEGIN -----------',bandNo,k) img_s = v[0] @@ -339,7 +339,7 @@ class MockObject(object): specImg.wcs = local_wcs specImg.setOrigin(origin_order_x, origin_order_y) try: - specImg = psf_model.get_PSF_AND_convolve_withsubImg(chip, cutImg=specImg, bandNo=bandNo, g_order=k, grating_split_pos=grating_split_pos) + specImg = psf_model.get_PSF_AND_convolve_withsubImg(chip, cutImg=specImg, pos_img_local=pos_img_local, bandNo=bandNo, g_order=k, grating_split_pos=grating_split_pos) except: psf, pos_shear = psf_model.get_PSF(chip=chip, pos_img=pos_img) diff --git a/observation_sim/psf/PSFInterpSLS.py b/observation_sim/psf/PSFInterpSLS.py index 0b534e2..81a4b5e 100644 --- a/observation_sim/psf/PSFInterpSLS.py +++ b/observation_sim/psf/PSFInterpSLS.py @@ -481,7 +481,7 @@ class PSFInterpSLS(PSFModel): return PSF_int_trans, PSF_int - def get_PSF_AND_convolve_withsubImg(self, chip, cutImg=None, bandNo=1, g_order='A', grating_split_pos=3685): + def get_PSF_AND_convolve_withsubImg(self, chip, cutImg=None, pos_img_local=[1000, 1000], bandNo=1, g_order='A', grating_split_pos=3685): """ Get the PSF at a given image position @@ -503,8 +503,8 @@ class PSFInterpSLS(PSFModel): # pos_img_x = pos_img_local[0] + x_start # pos_img_y = pos_img_local[1] + y_start # pos_img = galsim.PositionD(pos_img_x, pos_img_y) - centerPos_local = cutImg.ncol/2. - if centerPos_local < grating_split_pos: + # centerPos_local = cutImg.ncol/2. + if pos_img_local[0] < grating_split_pos: psf_data = self.grating1_data else: psf_data = self.grating2_data @@ -525,6 +525,7 @@ class PSFInterpSLS(PSFModel): npc = 10 m_size = int(pcs.shape[0]**0.5) + sumImg = np.sum(cutImg.array) tmp_img = cutImg*0 for j in np.arange(npc): X_ = jnp.hstack((pos_p[:,1].flatten()[:, None], pos_p[:,0].flatten()[:, None]),dtype=np.float32) @@ -534,43 +535,58 @@ class PSFInterpSLS(PSFModel): cy_len = int(chip.npix_y) n_x = jnp.arange(0, cx_len, 1, dtype = int) n_y = jnp.arange(0, cy_len, 1, dtype = int) - M, N = jnp.meshgrid(n_x, n_y) - t1=datetime.datetime.now() + # t1=datetime.datetime.now() # U = interpolate.griddata(X_, Z_, (M[0:cy_len, 0:cx_len],N[0:cy_len, 0:cx_len]), # method='nearest',fill_value=1.0) - ys = cutImg.ymin - if ys < 0: - ys = 0 - ye = cutImg.ymin+cutImg.nrow - if ye >= cy_len-1: - ye = cy_len-1 - if ye - ys <=0: - continue - xs = cutImg.xmin - if xs < 0: - xs = 0 - xe = cutImg.xmin+cutImg.ncol - if xe >= cx_len-1: - xe = cx_len-1 - if xe - xs <=0: + b_img = galsim.Image(cx_len, cy_len) + b_img.setOrigin(0,0) + bounds = cutImg.bounds & b_img.bounds + if bounds.area() == 0: continue + + # ys = cutImg.ymin + # if ys < 0: + # ys = 0 + # ye = cutImg.ymin+cutImg.nrow + # if ye >= cy_len-1: + # ye = cy_len-1 + # if ye - ys <=0: + # continue + # xs = cutImg.xmin + # if xs < 0: + # xs = 0 + # xe = cutImg.xmin+cutImg.ncol + # if xe >= cx_len-1: + # xe = cx_len-1 + # if xe - xs <=0: + # continue + ys = bounds.ymin + ye = bounds.ymax+1 + xs = bounds.xmin + xe = bounds.xmax+1 U = interpolate.griddata(X_, Z_, (M[ys:ye, xs:xe],N[ys:ye, xs:xe]), method='nearest',fill_value=1.0) - t2=datetime.datetime.now() + # t2=datetime.datetime.now() - print("time interpolate:", t2-t1) + # print("time interpolate:", t2-t1) - if U.shape != cutImg.array.shape: - print('DEBUG:SHAPE',cutImg.ncol,cutImg.nrow,cutImg.xmin, cutImg.ymin) - continue - img_tmp = cutImg.array*U + # if U.shape != cutImg.array.shape: + # print('DEBUG:SHAPE',cutImg.ncol,cutImg.nrow,cutImg.xmin, cutImg.ymin) + # continue + img_tmp = cutImg + img_tmp[bounds] = img_tmp[bounds]*U psf = pcs[:, j].reshape(m_size, m_size) - tmp_img = tmp_img + signal.fftconvolve(img_tmp, psf, mode='same', axes=None) + tmp_img = tmp_img + signal.fftconvolve(img_tmp.array, psf, mode='same', axes=None) - t3=datetime.datetime.now() - print("time convole:", t3-t2) + # t3=datetime.datetime.now() + # print("time convole:", t3-t2) del U + del img_tmp + if np.sum(tmp_img.array)==0: + tmp_img = cutImg + else: + tmp_img = tmp_img/np.sum(tmp_img.array)*sumImg return tmp_img @@ -644,17 +660,17 @@ class PSFInterpSLS(PSFModel): sub_size = 4 cx_len = int(chip.npix_x/sub_size) cy_len = int(chip.npix_y/sub_size) - n_x = jnp.arange(0, cx_len, 1, dtype = int) - n_y = jnp.arange(0, cy_len, 1, dtype = int) + n_x = jnp.arange(0, chip.npix_x, sub_size, dtype = int) + n_y = jnp.arange(0, chip.npix_y, sub_size, dtype = int) M, N = jnp.meshgrid(n_x, n_y) t1=datetime.datetime.now() # U = interpolate.griddata(X_, Z_, (M[0:cy_len, 0:cx_len],N[0:cy_len, 0:cx_len]), # method='nearest',fill_value=1.0) - U1 = interpolate.griddata(X_, Z_, (M[0:cy_len, 0:cx_len],N[0:cy_len, 0:cx_len]), + U1 = interpolate.griddata(X_, Z_, (M, N), method='nearest',fill_value=1.0) U = np.zeros_like(chip.img.array, dtype=np.float32) - for mi in np.arange(cx_len): + for mi in np.arange(cy_len): for mj in np.arange(cx_len): U[mi*sub_size:(mi+1)*sub_size, mj*sub_size:(mj+1)*sub_size]=U1[mi,mj] t2=datetime.datetime.now() -- GitLab From 5bfe67607c59cf36e6f999261693801ae515893c Mon Sep 17 00:00:00 2001 From: zhangxin Date: Thu, 11 Jul 2024 10:30:16 +0800 Subject: [PATCH 10/22] add calculate pointing center tools by defining chip center ra dec --- tools/get_pointing_accurcy.py | 165 ++++++++++++++++++++++++++++++++++ 1 file changed, 165 insertions(+) create mode 100644 tools/get_pointing_accurcy.py diff --git a/tools/get_pointing_accurcy.py b/tools/get_pointing_accurcy.py new file mode 100644 index 0000000..33d8575 --- /dev/null +++ b/tools/get_pointing_accurcy.py @@ -0,0 +1,165 @@ + +from pylab import * +import math, sys, numpy as np +import astropy.coordinates as coord +from astropy.coordinates import SkyCoord +from astropy import wcs, units as u +from observation_sim.config.header import ImageHeader +from observation_sim.instruments import Telescope, Chip, FilterParam, Filter, FocalPlane + + +def transRaDec2D(ra, dec): + x1 = np.cos(dec / 57.2957795) * np.cos(ra / 57.2957795) + y1 = np.cos(dec / 57.2957795) * np.sin(ra / 57.2957795) + z1 = np.sin(dec / 57.2957795) + return np.array([x1, y1, z1]) + +def ecl2radec(lon_ecl, lat_ecl): + ## convert from ecliptic coordinates to equatorial coordinates + c_ecl = SkyCoord( + lon=lon_ecl * u.degree, lat=lat_ecl * u.degree, frame="barycentrictrueecliptic" + ) + c_eq = c_ecl.transform_to("icrs") + ra_eq, dec_eq = c_eq.ra.degree, c_eq.dec.degree + return ra_eq, dec_eq + + +def radec2ecl(ra, dec): + ## convert from equatorial coordinates to ecliptic coordinates + c_eq = SkyCoord(ra=ra * u.degree, dec=dec * u.degree, frame="icrs") + c_ecl = c_eq.transform_to("barycentrictrueecliptic") + lon_ecl, lat_ecl = c_ecl.lon.degree, c_ecl.lat.degree + return lon_ecl, lat_ecl + +def cal_FoVcenter_1P_equatorial(ra_FieldCenter, dec_FieldCenter, chipID = 1, pa = -23.5): + + ### [ra_FieldCenter, dec_FieldCenter] is the center ra, dec of calibration fileds, such as: NEP, NGC 6397, etc. + ### [ra_ChipCenter, dec_ChipCenter] is the center ra, dec of the Chip center. + ### [ra_PointCenter, dec_PointCenter] is the telescope pointing center. + ## Calculate PA angle + chip = Chip(chipID) + + h_ext = ImageHeader.generateExtensionHeader( + chip=chip, + xlen=chip.npix_x, + ylen=chip.npix_y, + ra=(ra_FieldCenter * u.degree).value, + dec=(dec_FieldCenter * u.degree).value, + pa=pa, + gain=chip.gain, + readout=chip.read_noise, + dark=chip.dark_noise, + saturation=90000, + pixel_scale=chip.pix_scale, + pixel_size=chip.pix_size, + xcen=chip.x_cen, + ycen=chip.y_cen, + ) + + # assume that the telescope point to the sky center; then abtain the chip center under this situation; then calculate the differenc between the assumed telescope center and chip center; then add this difference to the sky center + + wcs_h = wcs.WCS(h_ext) + pixs = np.array([[4608, 4616]]) + world_point = wcs_h.wcs_pix2world(pixs, 0) + ra_ChipCenter, dec_ChipCenter = world_point[0][0], world_point[0][1] + + d_ra = ra_FieldCenter - ra_ChipCenter + d_dec = dec_FieldCenter - dec_ChipCenter + + ra_PointCenter = ra_FieldCenter + d_ra + dec_PointCenter = dec_FieldCenter + d_dec + + lon_ecl_PointCenter, lat_ecl_PointCenter = radec2ecl( + ra_PointCenter, dec_PointCenter + ) + + return ra_PointCenter, dec_PointCenter, lon_ecl_PointCenter, lat_ecl_PointCenter + +def cal_FoVcenter_1P_ecliptic(lon_ecl_FieldCenter, lat_ecl_FieldCenter, chipID = 1, pa = -23.5): + + ### [ra_FieldCenter, dec_FieldCenter] is the center ra, dec of calibration fileds, such as: NEP, NGC 6397, etc. + ### [ra_ChipCenter, dec_ChipCenter] is the center ra, dec of the Chip center. + ### [ra_PointCenter, dec_PointCenter] is the telescope pointing center. + + ra_FieldCenter, dec_FieldCenter = ecl2radec( + lon_ecl_FieldCenter, lat_ecl_FieldCenter + ) + + ## Calculate PA angle + chip = Chip(chipID) + + h_ext = ImageHeader.generateExtensionHeader( + chip=chip, + xlen=chip.npix_x, + ylen=chip.npix_y, + ra=(ra_FieldCenter * u.degree).value, + dec=(dec_FieldCenter * u.degree).value, + pa=pa, + gain=chip.gain, + readout=chip.read_noise, + dark=chip.dark_noise, + saturation=90000, + pixel_scale=chip.pix_scale, + pixel_size=chip.pix_size, + xcen=chip.x_cen, + ycen=chip.y_cen, + ) + + # assume that the telescope point to the sky center; then abtain the chip center under this situation; then calculate the differenc between the assumed telescope center and chip center; then add this difference to the sky center + + wcs_h = wcs.WCS(h_ext) + pixs = np.array([[4608, 4616]]) + world_point = wcs_h.wcs_pix2world(pixs, 0) + ra_ChipCenter, dec_ChipCenter = world_point[0][0], world_point[0][1] + + d_ra = ra_FieldCenter - ra_ChipCenter + d_dec = dec_FieldCenter - dec_ChipCenter + + ra_PointCenter = ra_FieldCenter + d_ra + dec_PointCenter = dec_FieldCenter + d_dec + + lon_ecl_PointCenter, lat_ecl_PointCenter = radec2ecl( + ra_PointCenter, dec_PointCenter + ) + + return ra_PointCenter, dec_PointCenter, lon_ecl_PointCenter, lat_ecl_PointCenter + +def getChipCenterRaDec(chipID = 1, p_ra = 60., p_dec = -40.): + chip = Chip(chipID) + + h_ext = ImageHeader.generateExtensionHeader( + chip=chip, + xlen=chip.npix_x, + ylen=chip.npix_y, + ra=(p_ra * u.degree).value, + dec=(p_dec * u.degree).value, + pa=pa, + gain=chip.gain, + readout=chip.read_noise, + dark=chip.dark_noise, + saturation=90000, + pixel_scale=chip.pix_scale, + pixel_size=chip.pix_size, + xcen=chip.x_cen, + ycen=chip.y_cen, + ) + wcs_h = wcs.WCS(h_ext) + pixs = np.array([[4608, 4616]]) + world_point = wcs_h.wcs_pix2world(pixs, 0) + RA_chip, Dec_chip = world_point[0][0], world_point[0][1] + return RA_chip, Dec_chip + +if __name__ == '__main__': + ra_input, dec_input = 270.00000, 66.56000 # NEP + pa = 23.5 + # chipid = 2 + + for chipid in np.arange(1,31,1): + ra, dec, lon_ecl, lat_ecl = cal_FoVcenter_1P_equatorial( + ra_input, dec_input,chipID=chipid, pa=pa) + + print("chip id is %d, chip center [ra,dec] is [%f, %f], pointing center calculated [ra,dec] is [%f, %f]"%(chipid, ra_input, dec_input, ra, dec)) + #for check the result + # testRA, testDec = getChipCenterRaDec(chipID = chipid, p_ra = ra, p_dec = dec) + # print(ra_input-testRA, dec_input-testDec) + -- GitLab From f5ae25788dafcf68e140f001796e5017e0f19134 Mon Sep 17 00:00:00 2001 From: fangyuedong Date: Mon, 15 Jul 2024 23:32:37 +0800 Subject: [PATCH 11/22] add radec_offsets (due to aberration compensation by FGS) to wcs projection --- observation_sim/ObservationSim.py | 7 ++++++- observation_sim/mock_objects/MockObject.py | 10 +++++----- observation_sim/sim_steps/__init__.py | 12 ++++++++---- observation_sim/sim_steps/add_objects.py | 2 +- 4 files changed, 20 insertions(+), 11 deletions(-) diff --git a/observation_sim/ObservationSim.py b/observation_sim/ObservationSim.py index 1e82700..247636f 100755 --- a/observation_sim/ObservationSim.py +++ b/observation_sim/ObservationSim.py @@ -92,16 +92,21 @@ class Observation(object): input_time_str=time_str ) ra_cen, dec_cen = ra_cen[0], dec_cen[0] + ra_offset, dec_offset = pointing.ra - ra_cen, pointing.dec - dec_cen else: ra_cen = pointing.ra dec_cen = pointing.dec + ra_offset, dec_offset = 0., 0. # Prepare necessary chip properties for simulation chip = self.prepare_chip_for_exposure(chip, ra_cen, dec_cen, pointing) # Initialize SimSteps sim_steps = SimSteps(overall_config=self.config, - chip_output=chip_output, all_filters=self.all_filters) + chip_output=chip_output, + all_filters=self.all_filters, + ra_offset=ra_offset, + dec_offset=dec_offset) for step in pointing.obs_param["call_sequence"]: if self.config["run_option"]["out_cat_only"]: diff --git a/observation_sim/mock_objects/MockObject.py b/observation_sim/mock_objects/MockObject.py index 12e3612..ef660ca 100755 --- a/observation_sim/mock_objects/MockObject.py +++ b/observation_sim/mock_objects/MockObject.py @@ -59,13 +59,13 @@ class MockObject(object): flux = self.getFluxFilter(filt) return flux * tel.pupil_area * exptime - def getPosWorld(self): - ra = self.param["ra"] - dec = self.param["dec"] + def getPosWorld(self, ra_offset=0., dec_offset=0.): + ra = self.param["ra"] + ra_offset + dec = self.param["dec"] + dec_offset return galsim.CelestialCoord(ra=ra * galsim.degrees, dec=dec * galsim.degrees) - def getPosImg_Offset_WCS(self, img, fdmodel=None, chip=None, verbose=True, chip_wcs=None, img_header=None): - self.posImg = img.wcs.toImage(self.getPosWorld()) + def getPosImg_Offset_WCS(self, img, fdmodel=None, chip=None, verbose=True, chip_wcs=None, img_header=None, ra_offset=0., dec_offset=0.): + self.posImg = img.wcs.toImage(self.getPosWorld(ra_offset, dec_offset)) self.localWCS = img.wcs.local(self.posImg) # Apply field distortion model if (fdmodel is not None) and (chip is not None): diff --git a/observation_sim/sim_steps/__init__.py b/observation_sim/sim_steps/__init__.py index 65a8e21..e8e2661 100644 --- a/observation_sim/sim_steps/__init__.py +++ b/observation_sim/sim_steps/__init__.py @@ -1,10 +1,13 @@ import os + class SimSteps: - def __init__(self, overall_config, chip_output, all_filters): + def __init__(self, overall_config, chip_output, all_filters, ra_offset=0., dec_offset=0.): self.overall_config = overall_config self.chip_output = chip_output self.all_filters = all_filters + self.ra_offset = ra_offset + self.dec_offset = dec_offset from .prepare_headers import prepare_headers, updateHeaderInfo from .add_sky_background import add_sky_background_sci, add_sky_flat_calibration, add_sky_background @@ -15,6 +18,7 @@ class SimSteps: from .readout_output import add_prescan_overscan, add_readout_noise, apply_gain, quantization_and_output from .add_LED_flat import add_LED_Flat + SIM_STEP_TYPES = { "scie_obs": "add_objects", "sky_background": "add_sky_background", @@ -31,6 +35,6 @@ SIM_STEP_TYPES = { "readout_noise": "add_readout_noise", "gain": "apply_gain", "quantization_and_output": "quantization_and_output", - "led_calib_model":"add_LED_Flat", - "sky_flatField":"add_sky_flat_calibration", -} \ No newline at end of file + "led_calib_model": "add_LED_Flat", + "sky_flatField": "add_sky_flat_calibration", +} diff --git a/observation_sim/sim_steps/add_objects.py b/observation_sim/sim_steps/add_objects.py index 9f41d36..b50c7af 100644 --- a/observation_sim/sim_steps/add_objects.py +++ b/observation_sim/sim_steps/add_objects.py @@ -145,7 +145,7 @@ def add_objects(self, chip, filt, tel, pointing, catalog, obs_param): # Get position of object on the focal plane pos_img, _, _, _, fd_shear = obj.getPosImg_Offset_WCS( - img=chip.img, fdmodel=fd_model, chip=chip, verbose=False, chip_wcs=chip_wcs, img_header=self.h_ext) + img=chip.img, fdmodel=fd_model, chip=chip, verbose=False, chip_wcs=chip_wcs, img_header=self.h_ext, ra_offset=self.ra_offset, dec_offset=self.dec_offset) # [TODO] For now, only consider objects which their centers (after field distortion) are projected within the focal plane # Otherwise they will be considered missed objects -- GitLab From f02a4de08692699023733bf0f486e829e229e839 Mon Sep 17 00:00:00 2001 From: chengliang Date: Tue, 16 Jul 2024 19:40:11 +0800 Subject: [PATCH 12/22] optimize gc.collect --- observation_sim/ObservationSim.py | 3 +++ observation_sim/sim_steps/add_objects.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/observation_sim/ObservationSim.py b/observation_sim/ObservationSim.py index 247636f..f80123a 100755 --- a/observation_sim/ObservationSim.py +++ b/observation_sim/ObservationSim.py @@ -135,6 +135,9 @@ class Observation(object): chip_output.Log_info("check running:1: pointing-%d chip-%d pid-%d memory-%6.2fGB" % (pointing.id, chip.chipID, os.getpid(), (psutil.Process(os.getpid()).memory_info().rss / 1024 / 1024 / 1024))) del chip.img + del chip.flat_img + del chip.prnu_img + del chip.shutter_img def runExposure_MPI_PointingList(self, pointing_list, chips=None): comm = MPI.COMM_WORLD diff --git a/observation_sim/sim_steps/add_objects.py b/observation_sim/sim_steps/add_objects.py index b50c7af..741d963 100644 --- a/observation_sim/sim_steps/add_objects.py +++ b/observation_sim/sim_steps/add_objects.py @@ -216,7 +216,7 @@ def add_objects(self, chip, filt, tel, pointing, catalog, obs_param): # Unload SED: obj.unload_SED() del obj - gc.collect() + # gc.collect() del psf_model gc.collect() -- GitLab From 398f62727d3a74f28c2fa73e8d725aaadd6e7886 Mon Sep 17 00:00:00 2001 From: zhangxin Date: Mon, 22 Jul 2024 16:35:31 +0800 Subject: [PATCH 13/22] modify sls psf convolve mode, first convolve psf, then pixel to image; fix Gaus psf bug --- observation_sim/ObservationSim.py | 2 +- observation_sim/mock_objects/Galaxy.py | 127 ++++++++++----- observation_sim/mock_objects/MockObject.py | 150 +++++++++++------- .../SpecDisperser/SpecDisperser.py | 66 ++++++-- .../SpecDisperser/disperse_c/disperse.pyx | 49 +++++- observation_sim/psf/PSFGauss.py | 4 +- observation_sim/psf/PSFInterpSLS.py | 9 ++ 7 files changed, 294 insertions(+), 113 deletions(-) diff --git a/observation_sim/ObservationSim.py b/observation_sim/ObservationSim.py index 2550c06..92ceac7 100755 --- a/observation_sim/ObservationSim.py +++ b/observation_sim/ObservationSim.py @@ -116,7 +116,7 @@ class Observation(object): ra_cen = pointing.ra dec_cen = pointing.dec - slsPSFOpt = True + slsPSFOpt = False # Prepare necessary chip properties for simulation chip = self.prepare_chip_for_exposure(chip, ra_cen, dec_cen, pointing, slsPSFOptim = slsPSFOpt) diff --git a/observation_sim/mock_objects/Galaxy.py b/observation_sim/mock_objects/Galaxy.py index c220621..b0404e7 100755 --- a/observation_sim/mock_objects/Galaxy.py +++ b/observation_sim/mock_objects/Galaxy.py @@ -323,28 +323,73 @@ class Galaxy(MockObject): # # if fd_shear is not None: # # gal = gal.shear(fd_shear) - starImg = gal.drawImage( - wcs=chip_wcs_local, offset=offset, method='real_space') - - origin_star = [y_nominal - (starImg.center.y - starImg.ymin), - x_nominal - (starImg.center.x - starImg.xmin)] - starImg.setOrigin(0, 0) + galImg_List = [] + try: + pos_img_local = [0,0] + x_start = chip.x_cen/chip.pix_size - chip.npix_x / 2. + y_start = chip.y_cen/chip.pix_size - chip.npix_y / 2. + pos_img_local[0] = pos_img.x - x_start + pos_img_local[1] = pos_img.y - y_start + nnx = 0 + nny = 0 + for order in ["A","B"]: + psf, pos_shear = psf_model.get_PSF( + chip, pos_img_local=pos_img_local, bandNo=i+1, galsimGSObject=True, g_order=order, grating_split_pos=grating_split_pos) + star_p = galsim.Convolve(psf, gal) + if nnx == 0: + galImg = star_p.drawImage(wcs=chip_wcs_local, offset=offset) + nnx = galImg.xmax - galImg.xmin + 1 + nny = galImg.ymax - galImg.ymin + 1 + else: + galImg = star_p.drawImage(nx = nnx, ny = nny, wcs=chip_wcs_local, offset=offset) + galImg.setOrigin(0, 0) + # n1 = np.sum(np.isinf(galImg.array)) + # n2 = np.sum(np.isnan(galImg.array)) + # if n1>0 or n2 > 0: + # print("DEBUG: Galaxy, inf:%d, nan:%d"%(n1, n2)) + if np.sum(np.isnan(galImg.array)) > 0: + # ERROR happens + return 2, pos_shear + galImg_List.append(galImg) + for order in ["C","D","E"]: + galImg_List.append(galImg) + except: + psf, pos_shear = psf_model.get_PSF(chip=chip, pos_img=pos_img) + star_p = galsim.Convolve(psf, gal) + galImg = star_p.drawImage(wcs=chip_wcs_local, offset=offset) + galImg.setOrigin(0, 0) + if np.sum(np.isnan(galImg.array)) > 0: + # ERROR happens + return 2, pos_shear + for order in ["A","B","C","D","E"]: + galImg_List.append(galImg) + + # starImg = gal.drawImage( + # wcs=chip_wcs_local, offset=offset, method='real_space') + + origin_star = [y_nominal - (galImg.center.y - galImg.ymin), + x_nominal - (galImg.center.x - galImg.xmin)] + galImg.setOrigin(0, 0) gal_origin = [origin_star[0], origin_star[1]] - gal_end = [origin_star[0] + starImg.array.shape[0] - - 1, origin_star[1] + starImg.array.shape[1] - 1] + gal_end = [origin_star[0] + galImg.array.shape[0] - + 1, origin_star[1] + galImg.array.shape[1] - 1] if gal_origin[1] < grating_split_pos_chip < gal_end[1]: subSlitPos = int(grating_split_pos_chip - gal_origin[1] + 1) # part img disperse - subImg_p1 = starImg.array[:, 0:subSlitPos] - star_p1 = galsim.Image(subImg_p1) - star_p1.setOrigin(0, 0) + star_p1s=[] + for galImg in galImg_List: + + subImg_p1 = galImg.array[:, 0:subSlitPos] + star_p1 = galsim.Image(subImg_p1) + star_p1.setOrigin(0, 0) + star_p1s.append(star_p1) origin_p1 = origin_star xcenter_p1 = min(x_nominal, grating_split_pos_chip-1) - 0 ycenter_p1 = y_nominal-0 - sdp_p1 = SpecDisperser(orig_img=star_p1, xcenter=xcenter_p1, + sdp_p1 = SpecDisperser(orig_img=star_p1s, xcenter=xcenter_p1, ycenter=ycenter_p1, origin=origin_p1, tar_spec=normalSED, band_start=brange[0], band_end=brange[1], @@ -352,21 +397,25 @@ class Galaxy(MockObject): isAlongY=0, flat_cube=flat_cube) - # self.addSLStoChipImage(sdp=sdp_p1, chip=chip, xOrderSigPlus = xOrderSigPlus, local_wcs=chip_wcs_local) - pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp_p1, chip=chip, pos_img_local=[xcenter_p1, ycenter_p1], - psf_model=psf_model, bandNo=i + 1, - grating_split_pos=grating_split_pos, - local_wcs=chip_wcs_local, pos_img=pos_img) + self.addSLStoChipImage(sdp=sdp_p1, chip=chip, xOrderSigPlus = xOrderSigPlus, local_wcs=chip_wcs_local) + # pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp_p1, chip=chip, pos_img_local=[xcenter_p1, ycenter_p1], + # psf_model=psf_model, bandNo=i + 1, + # grating_split_pos=grating_split_pos, + # local_wcs=chip_wcs_local, pos_img=pos_img) + + star_p2s=[] + for galImg in galImg_List: - subImg_p2 = starImg.array[:, - subSlitPos+1:starImg.array.shape[1]] - star_p2 = galsim.Image(subImg_p2) - star_p2.setOrigin(0, 0) + subImg_p2 = galImg.array[:, + subSlitPos + 1:galImg.array.shape[1]] + star_p2 = galsim.Image(subImg_p2) + star_p2.setOrigin(0, 0) + star_p2s.append(star_p2) origin_p2 = [origin_star[0], grating_split_pos_chip] xcenter_p2 = max(x_nominal, grating_split_pos_chip - 1) - 0 ycenter_p2 = y_nominal - 0 - sdp_p2 = SpecDisperser(orig_img=star_p2, xcenter=xcenter_p2, + sdp_p2 = SpecDisperser(orig_img=star_p2s, xcenter=xcenter_p2, ycenter=ycenter_p2, origin=origin_p2, tar_spec=normalSED, band_start=brange[0], band_end=brange[1], @@ -374,41 +423,41 @@ class Galaxy(MockObject): isAlongY=0, flat_cube=flat_cube) - # self.addSLStoChipImage(sdp=sdp_p2, chip=chip, xOrderSigPlus = xOrderSigPlus, local_wcs=chip_wcs_local) - pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp_p2, chip=chip, pos_img_local=[xcenter_p2, ycenter_p2], - psf_model=psf_model, bandNo=i + 1, - grating_split_pos=grating_split_pos, - local_wcs=chip_wcs_local, pos_img=pos_img) + self.addSLStoChipImage(sdp=sdp_p2, chip=chip, xOrderSigPlus = xOrderSigPlus, local_wcs=chip_wcs_local) + # pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp_p2, chip=chip, pos_img_local=[xcenter_p2, ycenter_p2], + # psf_model=psf_model, bandNo=i + 1, + # grating_split_pos=grating_split_pos, + # local_wcs=chip_wcs_local, pos_img=pos_img) del sdp_p1 del sdp_p2 elif grating_split_pos_chip <= gal_origin[1]: - sdp = SpecDisperser(orig_img=starImg, xcenter=x_nominal - 0, + sdp = SpecDisperser(orig_img=galImg_List, xcenter=x_nominal - 0, ycenter=y_nominal - 0, origin=origin_star, tar_spec=normalSED, band_start=brange[0], band_end=brange[1], conf=chip.sls_conf[1], isAlongY=0, flat_cube=flat_cube) - # self.addSLStoChipImage(sdp=sdp, chip=chip, xOrderSigPlus = xOrderSigPlus, local_wcs=chip_wcs_local) - pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp, chip=chip, pos_img_local=[x_nominal, y_nominal], - psf_model=psf_model, bandNo=i + 1, - grating_split_pos=grating_split_pos, - local_wcs=chip_wcs_local, pos_img=pos_img) + self.addSLStoChipImage(sdp=sdp, chip=chip, xOrderSigPlus = xOrderSigPlus, local_wcs=chip_wcs_local) + # pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp, chip=chip, pos_img_local=[x_nominal, y_nominal], + # psf_model=psf_model, bandNo=i + 1, + # grating_split_pos=grating_split_pos, + # local_wcs=chip_wcs_local, pos_img=pos_img) del sdp elif grating_split_pos_chip >= gal_end[1]: - sdp = SpecDisperser(orig_img=starImg, xcenter=x_nominal - 0, + sdp = SpecDisperser(orig_img=galImg_List, xcenter=x_nominal - 0, ycenter=y_nominal - 0, origin=origin_star, tar_spec=normalSED, band_start=brange[0], band_end=brange[1], conf=chip.sls_conf[0], isAlongY=0, flat_cube=flat_cube) - # self.addSLStoChipImage(sdp=sdp, chip=chip, xOrderSigPlus = xOrderSigPlus, local_wcs=chip_wcs_local) - pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp, chip=chip, pos_img_local=[x_nominal, y_nominal], - psf_model=psf_model, bandNo=i + 1, - grating_split_pos=grating_split_pos, - local_wcs=chip_wcs_local, pos_img=pos_img) + self.addSLStoChipImage(sdp=sdp, chip=chip, xOrderSigPlus = xOrderSigPlus, local_wcs=chip_wcs_local) + # pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp, chip=chip, pos_img_local=[x_nominal, y_nominal], + # psf_model=psf_model, bandNo=i + 1, + # grating_split_pos=grating_split_pos, + # local_wcs=chip_wcs_local, pos_img=pos_img) del sdp # print(self.y_nominal, starImg.center.y, starImg.ymin) diff --git a/observation_sim/mock_objects/MockObject.py b/observation_sim/mock_objects/MockObject.py index 5927d95..bcf550d 100755 --- a/observation_sim/mock_objects/MockObject.py +++ b/observation_sim/mock_objects/MockObject.py @@ -196,33 +196,26 @@ class MockObject(object): # DEBUG ######################################################### # print("before convolveGaussXorders, img_s:", img_s) - nan_ids = np.isnan(img_s) - if img_s[nan_ids].shape[0] > 0: - # img_s[nan_ids] = 0 - print("DEBUG: before convolveGaussXorders specImg nan num is", - img_s[nan_ids].shape[0]) + # nan_ids = np.isnan(img_s) + # if img_s[nan_ids].shape[0] > 0: + # # img_s[nan_ids] = 0 + # print("DEBUG: before convolveGaussXorders specImg nan num is", + # img_s[nan_ids].shape[0]) ######################################################### - img_s, orig_off = convolveGaussXorders(img_s, xOrderSigPlus[k]) + # img_s, orig_off = convolveGaussXorders(img_s, xOrderSigPlus[k]) + orig_off = 0 origin_order_x = v[1] - orig_off origin_order_y = v[2] - orig_off - ######################################################### # DEBUG ######################################################### # print("DEBUG: orig_off is", orig_off) - nan_ids = np.isnan(img_s) - if img_s[nan_ids].shape[0] > 0: - img_s[nan_ids] = 0 - print("DEBUG: specImg nan num is", img_s[nan_ids].shape[0]) + # nan_ids = np.isnan(img_s) + # if img_s[nan_ids].shape[0] > 0: + # img_s[nan_ids] = 0 + # print("DEBUG: specImg nan num is", img_s[nan_ids].shape[0]) ######################################################### - specImg = galsim.ImageF(img_s) - photons = galsim.PhotonArray.makeFromImage(specImg) - photons.x += origin_order_x - photons.y += origin_order_y - - xlen_imf = int(specImg.xmax - specImg.xmin + 1) - ylen_imf = int(specImg.ymax - specImg.ymin + 1) - stamp = galsim.ImageF(xlen_imf, ylen_imf) + stamp = galsim.ImageF(img_s) stamp.wcs = local_wcs stamp.setOrigin(origin_order_x, origin_order_y) @@ -231,9 +224,7 @@ class MockObject(object): if bounds.area() == 0: continue chip.img.setOrigin(0, 0) - stamp[bounds] = chip.img[bounds] - chip.sensor.accumulate(photons, stamp) - chip.img[bounds] = stamp[bounds] + chip.img[bounds] = chip.img[bounds]+stamp[bounds] chip.img.setOrigin(chip.bound.xmin, chip.bound.ymin) del stamp del spec_orders @@ -430,32 +421,76 @@ class MockObject(object): # psf, pos_shear = psf_model.get_PSF(chip=chip, pos_img=pos_img, bandpass=bandpass, # folding_threshold=folding_threshold) - star = galsim.DeltaFunction(gsparams=gsp) - star = star.withFlux(tel.pupil_area * exptime) - psf_tmp = galsim.Gaussian(sigma=0.002) - star = galsim.Convolve(psf_tmp, star) - starImg = star.drawImage( - nx=60, ny=60, wcs=chip_wcs_local, offset=offset) + # star = galsim.DeltaFunction(gsparams=gsp) + # star = star.withFlux(tel.pupil_area * exptime) + + #psf list :["A","B","C","D","E"] + starImg_List = [] + try: + pos_img_local = [0,0] + x_start = chip.x_cen/chip.pix_size - chip.npix_x / 2. + y_start = chip.y_cen/chip.pix_size - chip.npix_y / 2. + pos_img_local[0] = pos_img.x - x_start + pos_img_local[1] = pos_img.y - y_start + nnx = 0 + nny = 0 + for order in ["A","B"]: + psf, pos_shear = psf_model.get_PSF( + chip, pos_img_local=pos_img_local, bandNo=i+1, galsimGSObject=True, g_order=order, grating_split_pos=grating_split_pos) + # star_p = galsim.Convolve(psf, star) + star_p = psf.withFlux(tel.pupil_area * exptime) + if nnx == 0: + starImg = star_p.drawImage(wcs=chip_wcs_local, offset=offset) + nnx = starImg.xmax - starImg.xmin + 1 + nny = starImg.ymax - starImg.ymin + 1 + else: + starImg = star_p.drawImage(nx = nnx, ny = nny, wcs=chip_wcs_local, offset=offset) + # n1 = np.sum(np.isinf(starImg.array)) + # n2 = np.sum(np.isnan(starImg.array)) + # if n1>0 or n2 > 0: + # print("DEBUG: MockObject, inf:%d, nan:%d"%(n1, n2)) + starImg.setOrigin(0, 0) + starImg_List.append(starImg) + for order in ["C","D","E"]: + starImg_List.append(starImg) + except: + psf, pos_shear = psf_model.get_PSF(chip=chip, pos_img=pos_img) + # star_p = galsim.Convolve(psf, star) + star_p = psf.withFlux(tel.pupil_area * exptime) + starImg = star_p.drawImage(wcs=chip_wcs_local, offset=offset) + starImg.setOrigin(0, 0) + for order in ["A","B","C","D","E"]: + starImg_List.append(starImg) + + + # psf_tmp = galsim.Gaussian(sigma=0.002) + # star = galsim.Convolve(psf_tmp, star) + + # starImg = star.drawImage( + # nx=60, ny=60, wcs=chip_wcs_local, offset=offset) origin_star = [y_nominal - (starImg.center.y - starImg.ymin), x_nominal - (starImg.center.x - starImg.xmin)] - starImg.setOrigin(0, 0) + gal_origin = [origin_star[0], origin_star[1]] gal_end = [origin_star[0] + starImg.array.shape[0] - 1, origin_star[1] + starImg.array.shape[1] - 1] if gal_origin[1] < grating_split_pos_chip < gal_end[1]: subSlitPos = int(grating_split_pos_chip - gal_origin[1] + 1) # part img disperse + star_p1s=[] + for starImg in starImg_List: - subImg_p1 = starImg.array[:, 0:subSlitPos] - star_p1 = galsim.Image(subImg_p1) + subImg_p1 = starImg.array[:, 0:subSlitPos] + star_p1 = galsim.Image(subImg_p1) + star_p1.setOrigin(0, 0) + star_p1s.append(star_p1) origin_p1 = origin_star - star_p1.setOrigin(0, 0) xcenter_p1 = min(x_nominal, grating_split_pos_chip - 1) - 0 ycenter_p1 = y_nominal - 0 - sdp_p1 = SpecDisperser(orig_img=star_p1, xcenter=xcenter_p1, + sdp_p1 = SpecDisperser(orig_img=star_p1s, xcenter=xcenter_p1, ycenter=ycenter_p1, origin=origin_p1, tar_spec=normalSED, band_start=brange[0], band_end=brange[1], @@ -463,20 +498,25 @@ class MockObject(object): isAlongY=0, flat_cube=flat_cube) - # self.addSLStoChipImage(sdp=sdp_p1, chip=chip, xOrderSigPlus=xOrderSigPlus, local_wcs=chip_wcs_local) - pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp_p1, chip=chip, pos_img_local=[xcenter_p1, ycenter_p1], - psf_model=psf_model, bandNo=i+1, grating_split_pos=grating_split_pos, - local_wcs=chip_wcs_local, pos_img=pos_img) + self.addSLStoChipImage(sdp=sdp_p1, chip=chip, xOrderSigPlus=xOrderSigPlus, local_wcs=chip_wcs_local) + # pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp_p1, chip=chip, pos_img_local=[xcenter_p1, ycenter_p1], + # psf_model=psf_model, bandNo=i+1, grating_split_pos=grating_split_pos, + # local_wcs=chip_wcs_local, pos_img=pos_img) + + + star_p2s=[] + for starImg in starImg_List: - subImg_p2 = starImg.array[:, + subImg_p2 = starImg.array[:, subSlitPos + 1:starImg.array.shape[1]] - star_p2 = galsim.Image(subImg_p2) - star_p2.setOrigin(0, 0) + star_p2 = galsim.Image(subImg_p2) + star_p2.setOrigin(0, 0) + star_p2s.append(star_p2) origin_p2 = [origin_star[0], grating_split_pos_chip] xcenter_p2 = max(x_nominal, grating_split_pos_chip - 1) - 0 ycenter_p2 = y_nominal - 0 - sdp_p2 = SpecDisperser(orig_img=star_p2, xcenter=xcenter_p2, + sdp_p2 = SpecDisperser(orig_img=star_p2s, xcenter=xcenter_p2, ycenter=ycenter_p2, origin=origin_p2, tar_spec=normalSED, band_start=brange[0], band_end=brange[1], @@ -484,38 +524,38 @@ class MockObject(object): isAlongY=0, flat_cube=flat_cube) - # self.addSLStoChipImage(sdp=sdp_p2, chip=chip, xOrderSigPlus=xOrderSigPlus, local_wcs=chip_wcs_local) - pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp_p2, chip=chip, pos_img_local=[xcenter_p2, ycenter_p2], - psf_model=psf_model, bandNo=i + 1, grating_split_pos=grating_split_pos, - local_wcs=chip_wcs_local, pos_img=pos_img) + self.addSLStoChipImage(sdp=sdp_p2, chip=chip, xOrderSigPlus=xOrderSigPlus, local_wcs=chip_wcs_local) + # pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp_p2, chip=chip, pos_img_local=[xcenter_p2, ycenter_p2], + # psf_model=psf_model, bandNo=i + 1, grating_split_pos=grating_split_pos, + # local_wcs=chip_wcs_local, pos_img=pos_img) del sdp_p1 del sdp_p2 elif grating_split_pos_chip <= gal_origin[1]: - sdp = SpecDisperser(orig_img=starImg, xcenter=x_nominal - 0, + sdp = SpecDisperser(orig_img=starImg_List, xcenter=x_nominal - 0, ycenter=y_nominal - 0, origin=origin_star, tar_spec=normalSED, band_start=brange[0], band_end=brange[1], conf=chip.sls_conf[1], isAlongY=0, flat_cube=flat_cube) - # self.addSLStoChipImage(sdp=sdp, chip=chip, xOrderSigPlus=xOrderSigPlus, local_wcs=chip_wcs_local) - pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp, chip=chip, pos_img_local=[x_nominal, y_nominal], - psf_model=psf_model, bandNo=i + 1, grating_split_pos=grating_split_pos, - local_wcs=chip_wcs_local, pos_img=pos_img) + self.addSLStoChipImage(sdp=sdp, chip=chip, xOrderSigPlus=xOrderSigPlus, local_wcs=chip_wcs_local) + # pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp, chip=chip, pos_img_local=[x_nominal, y_nominal], + # psf_model=psf_model, bandNo=i + 1, grating_split_pos=grating_split_pos, + # local_wcs=chip_wcs_local, pos_img=pos_img) del sdp elif grating_split_pos_chip >= gal_end[1]: - sdp = SpecDisperser(orig_img=starImg, xcenter=x_nominal - 0, + sdp = SpecDisperser(orig_img=starImg_List, xcenter=x_nominal - 0, ycenter=y_nominal - 0, origin=origin_star, tar_spec=normalSED, band_start=brange[0], band_end=brange[1], conf=chip.sls_conf[0], isAlongY=0, flat_cube=flat_cube) - # self.addSLStoChipImage(sdp=sdp, chip=chip, xOrderSigPlus=xOrderSigPlus, local_wcs=chip_wcs_local) - pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp, chip=chip, pos_img_local=[x_nominal, y_nominal], - psf_model=psf_model, bandNo=i + 1, grating_split_pos=grating_split_pos, - local_wcs=chip_wcs_local, pos_img=pos_img) + self.addSLStoChipImage(sdp=sdp, chip=chip, xOrderSigPlus=xOrderSigPlus, local_wcs=chip_wcs_local) + # pos_shear = self.addSLStoChipImageWithPSF(sdp=sdp, chip=chip, pos_img_local=[x_nominal, y_nominal], + # psf_model=psf_model, bandNo=i + 1, grating_split_pos=grating_split_pos, + # local_wcs=chip_wcs_local, pos_img=pos_img) del sdp # del psf return 1, pos_shear diff --git a/observation_sim/mock_objects/SpecDisperser/SpecDisperser.py b/observation_sim/mock_objects/SpecDisperser/SpecDisperser.py index 6a1e3ef..2b2d7c2 100644 --- a/observation_sim/mock_objects/SpecDisperser/SpecDisperser.py +++ b/observation_sim/mock_objects/SpecDisperser/SpecDisperser.py @@ -65,10 +65,30 @@ class SpecDisperser(object): # self.img_x = orig_img.shape[1] # self.img_y = orig_img.shape[0] - self.thumb_img = np.abs(orig_img.array) - self.thumb_x = orig_img.center.x - self.thumb_y = orig_img.center.y - self.img_sh = orig_img.array.shape + # 5 orders, A, B , + orderName=["A","B","C","D","E"] + self.orig_img_orders = OrderedDict() + if isinstance(orig_img, list): + orig_img_list = orig_img + list_len = len(orig_img_list) + if list_len < 5: + for i in np.arange(5-list_len): + orig_img_list.append(orig_img_list[list_len-1]) + for i, k in enumerate(orig_img_list): + self.orig_img_orders[orderName[i]] = k + + + if isinstance(orig_img, galsim.Image): + for i in np.arange(5): + self.orig_img_orders[orderName[i]] = orig_img + + + orig_img_one = self.orig_img_orders["A"] + + self.thumb_img = np.abs(orig_img_one.array) + self.thumb_x = orig_img_one.center.x + self.thumb_y = orig_img_one.center.y + self.img_sh = orig_img_one.array.shape self.id = gid @@ -78,10 +98,13 @@ class SpecDisperser(object): self.isAlongY = isAlongY self.flat_cube = flat_cube if self.isAlongY == 1: - self.thumb_img, self.thumb_x, self.thumb_y = rotate90(array_orig=self.thumb_img, xc=orig_img.center.x, - yc=orig_img.center.y, isClockwise=1) + for order in orderName: + self.orig_img_orders[order], self.thumb_x, self.thumb_y = rotate90(array_orig=self.orig_img_orders[order], xc=orig_img_one.center.x, + yc=orig_img_one.center.y, isClockwise=1) + # self.thumb_img, self.thumb_x, self.thumb_y = rotate90(array_orig=self.thumb_img, xc=orig_img_one.center.x, + # yc=orig_img_one.center.y, isClockwise=1) - self.img_sh = orig_img.array.T.shape + self.img_sh = self.orig_img_orders[order].array.T.shape self.xcenter = ycenter self.ycenter = xcenter @@ -111,10 +134,16 @@ class SpecDisperser(object): def compute_spec(self, beam): + # if beam == "B": + # return self.thumb_img, self.origin[1], self.origin[0], None, None, None + from .disperse_c import interp from .disperse_c import disperse # from MockObject.disperse_c import disperse - + self.thumb_img = np.abs(self.orig_img_orders[beam].array) + self.thumb_x = self.orig_img_orders[beam].center.x + self.thumb_y = self.orig_img_orders[beam].center.y + self.img_sh = self.orig_img_orders[beam].array.shape dx = self.grating_conf.dxlam[beam] xoff = 0 ytrace_beam, lam_beam = self.grating_conf.get_beam_trace(x=self.xcenter, y=self.ycenter, dx=(dx + xoff), @@ -169,7 +198,8 @@ class SpecDisperser(object): dyc = cast[int](np.floor(ytrace_beam+0.5)) - dypix = cast[int](np.floor(ytrace_beam - dyc[0] + x0[0] + 0.5)) + # dypix = cast[int](np.floor(ytrace_beam - dyc[0] + x0[0] + 0.5)) + dypix = dyc - dyc[0] + x0[0] frac_ids = yfrac_beam < 0 @@ -248,7 +278,8 @@ class SpecDisperser(object): # beam_flat[k] = self.flat_cube[:, originOut_y + i, originOut_x + j] status = disperse.disperse_grism_object(self.thumb_img.astype(np.float32), - flat_index[nonz], yfrac_beam[nonz], + flat_index[nonz], + yfrac_beam[nonz], sensitivity_beam[nonz], modelf, x0, array(self.img_sh, @@ -258,11 +289,24 @@ class SpecDisperser(object): lam_beam[lam_index][nonz]) model = modelf.reshape(beam_sh) + # n1 = np.sum(np.isinf(model)) + # n2 = np.sum(np.isnan(model)) + # n3 = np.sum(np.isinf(modelf)) + # n4 = np.sum(np.isnan(modelf)) + # if n1>0 or n2 > 0: + # print("DEBUG: SpecDisperser, inf:%d, nan:%d--------%d,%d"%(n1, n2, n3, n4)) + # print(dypix) + # n1 = np.sum(np.isinf(self.thumb_img.astype(np.float32))) + # n2 = np.sum(np.isnan(self.thumb_img.astype(np.float32))) + # n3 = np.sum(np.isinf(yfrac_beam)) + # n4 = np.sum(np.isnan(yfrac_beam)) + # n5 = np.sum(np.isinf(sensitivity_beam)) + # n6 = np.sum(np.isnan(sensitivity_beam)) + # print("DEBUG: SpecDisperser, innput ---inf:%d, nan:%d, yfrac_beam:%d/%d, sensitivity_beam:%d/%d"%(n1, n2, n3, n4, n5, n6)) self.beam_flux[beam] = sum(modelf) if self.isAlongY == 1: model, _, _ = rotate90(array_orig=model, isClockwise=0) - return model, originOut_x, originOut_y, dxpix, dypix, lam_beam, ysens def writerSensitivityFile(self, conffile='', beam='', w=None, sens=None): diff --git a/observation_sim/mock_objects/SpecDisperser/disperse_c/disperse.pyx b/observation_sim/mock_objects/SpecDisperser/disperse_c/disperse.pyx index 41dbf14..707c670 100644 --- a/observation_sim/mock_objects/SpecDisperser/disperse_c/disperse.pyx +++ b/observation_sim/mock_objects/SpecDisperser/disperse_c/disperse.pyx @@ -20,7 +20,30 @@ import cython cdef extern from "math.h": double sqrt(double x) double exp(double x) + + +def check_nan2D(np.ndarray[FTYPE_t, ndim=2] arr): + cdef int i, j + cdef int nrows = arr.shape[0] + cdef int ncols = arr.shape[1] + # 遍历数组的每个元素并检查是否存在 NaN + for i in range(nrows): + for j in range(ncols): + if np.isnan(arr[i, j]) | np.isinf(arr[i, j]): + return True + return False + +def check_nan1d(np.ndarray[DTYPE_t, ndim=1] arr): + cdef int i + cdef int n = arr.shape[0] + + # 遍历数组的每个元素并检查是否存在 NaN + for i in range(n): + if np.isnan(arr[i]) | np.isinf(arr[i]): + return True + return False + @cython.boundscheck(False) @cython.wraparound(False) @cython.embedsignature(True) @@ -53,6 +76,18 @@ def disperse_grism_object(np.ndarray[FTYPE_t, ndim=2] flam, nk = len(idxl) nl = len(full) + + + #if check_nan2D(flam): + # print("DEBUG: disperse, input Array 'flam' contains NaN.") + #if check_nan1d(ysens): + # print("DEBUG: disperse, input Array 'ysens' contains NaN.") + #if check_nan1d(yfrac): + # print("DEBUG: disperse, input Array 'yfrac' contains NaN.") + #if check_nan1d(full): + # print("DEBUG: disperse, input Array 'full' contains NaN before processing.") + + if (flat is not None): nlamb = len(wlambda) @@ -95,14 +130,15 @@ def disperse_grism_object(np.ndarray[FTYPE_t, ndim=2] flam, else: for i in range(0-x0[1], x0[1]): - if (x0[1]+i < 0) | (x0[1]+i >= shd[1]): + x_pos = x0[1]+i + if (x_pos < 0) | (x_pos >= shd[1]): continue for j in range(0-x0[0], x0[0]): - if (x0[0]+j < 0) | (x0[0]+j >= shd[0]): + y_pos = x0[0]+j + if (y_pos < 0) | (y_pos >= shd[0]): continue - - fl_ij = flam[x0[0]+j, x0[1]+i] #/1.e-17 + fl_ij = flam[y_pos, x_pos] #/1.e-17 if (fl_ij == 0): continue @@ -110,10 +146,13 @@ def disperse_grism_object(np.ndarray[FTYPE_t, ndim=2] flam, k1 = idxl[k]+j*shg[1]+i if (k1 >= 0) & (k1 < nl): full[k1] += ysens[k]*fl_ij*(1-yfrac[k]) - k2 = idxl[k]+(j+1)*shg[1]+i if (k2 >= 0) & (k2 < nl): full[k2] += ysens[k]*fl_ij*yfrac[k] + + #if (check_nan1d(full)): + # print("DEBUG: disperse, output Array 'full' contains NaN after processing.+++++++++++++++++++++++++++") + return True diff --git a/observation_sim/psf/PSFGauss.py b/observation_sim/psf/PSFGauss.py index a21b0c8..e3036d9 100644 --- a/observation_sim/psf/PSFGauss.py +++ b/observation_sim/psf/PSFGauss.py @@ -17,7 +17,7 @@ class PSFGauss(PSFModel): self.fwhm = self.fwhmGauss(r=psfRa) self.sigGauss = psfRa # 80% light radius self.sigSpin = sigSpin - self.psf = galsim.Gaussian(flux=1.0, fwhm=fwhm) + self.psf = galsim.Gaussian(flux=1.0, fwhm=self.fwhm) def perfGauss(self, r, sig): """ @@ -122,4 +122,4 @@ class PSFGauss(PSFModel): # return ell, beta, qr PSFshear = galsim.Shear(e=ell, beta=beta*galsim.radians) - return self.psf.shear(PSFshear), PSFshear + return self.psf.shear(PSFshear), PSFshear \ No newline at end of file diff --git a/observation_sim/psf/PSFInterpSLS.py b/observation_sim/psf/PSFInterpSLS.py index 81a4b5e..7a68b3b 100644 --- a/observation_sim/psf/PSFInterpSLS.py +++ b/observation_sim/psf/PSFInterpSLS.py @@ -435,7 +435,16 @@ class PSFInterpSLS(PSFModel): # PSF_int_trans[ids_szero] = 0 # print(PSF_int_trans[ids_szero].shape[0],PSF_int_trans.shape) PSF_int_trans = PSF_int_trans/np.sum(PSF_int_trans) + ###DEBGU + ids_szero = PSF_int_trans<0 + n01 = PSF_int_trans[ids_szero].shape[0] + n1 = np.sum(np.isinf(PSF_int_trans)) + n2 = np.sum(np.isnan(PSF_int_trans)) + if n1>0 or n2>0: + print("DEBUG: PSFInterpSLS, inf:%d, nan:%d, 0 num:%d"%(n1, n2, n01)) + + #### # from astropy.io import fits # fits.writeto(str(bandNo) + '_' + g_order+ '_psf_o.fits', PSF_int_trans) -- GitLab From 5e8554bd4b6f4a991c13d22fe72f670231614458 Mon Sep 17 00:00:00 2001 From: fangyuedong Date: Mon, 22 Jul 2024 23:11:09 +0800 Subject: [PATCH 14/22] add milky way extinction for galaxy --- catalog/C9_Catalog.py | 19 +++- config/config_overall.yaml | 6 +- config/obs_config_SCI.yaml | 2 +- observation_sim/mock_objects/ExtinctionMW.py | 95 ++++++++++++++++++++ observation_sim/mock_objects/__init__.py | 1 + submit_jobs.slurm | 6 +- 6 files changed, 121 insertions(+), 8 deletions(-) create mode 100644 observation_sim/mock_objects/ExtinctionMW.py diff --git a/catalog/C9_Catalog.py b/catalog/C9_Catalog.py index 948fc96..978d74d 100644 --- a/catalog/C9_Catalog.py +++ b/catalog/C9_Catalog.py @@ -12,7 +12,7 @@ from astropy.table import Table from scipy import interpolate from datetime import datetime -from observation_sim.mock_objects import CatalogBase, Star, Galaxy, Quasar +from observation_sim.mock_objects import CatalogBase, Star, Galaxy, Quasar, ExtinctionMW from observation_sim.mock_objects._util import tag_sed, getObservedSED, getABMAG, integrate_sed_bandpass, comoving_dist from observation_sim.astrometry.Astrometry_util import on_orbit_obs_position @@ -110,6 +110,12 @@ class Catalog(CatalogBase): self.max_size = 0. + # [TODO] Milky Way extinction + self.mw_ext = ExtinctionMW() + self.mw_ext.init_ext_model(model_name="odonnell") + self.mw_ext.load_Planck_ext( + file_path="/public/home/fangyuedong/project/ext_maps/planck/HFI_CompMap_ThermalDustModel_2048_R1.20.fits") + if "star_cat" in config["catalog_options"]["input_path"] and config["catalog_options"]["input_path"]["star_cat"] and not config["catalog_options"]["galaxy_only"]: # Get the cloest star catalog file star_file_name = get_star_cat( @@ -248,6 +254,9 @@ class Catalog(CatalogBase): input_time_str=time_str ) + # [TODO] get Milky Way extinction AVs + MW_Av_arr = self.mw_ext.Av_from_Planck(ra=ra_arr, dec=dec_arr) + for igals in range(ngals): # # (TEST) # if igals > 100: @@ -259,6 +268,9 @@ class Catalog(CatalogBase): param['ra_orig'] = gals['ra'][igals] param['dec_orig'] = gals['dec'][igals] + # [TODO] get Milky Way extinction AVs + param['mw_Av'] = MW_Av_arr[igals] + if not self.chip.isContainObj(ra_obj=param['ra'], dec_obj=param['dec'], margin=200): continue @@ -530,6 +542,11 @@ class Catalog(CatalogBase): speci = interpolate.interp1d(wave, flux) lamb = np.arange(2000, 11001+0.5, 0.5) y = speci(lamb) + + # [TODO] Apply Milky Way extinction + if obj.type != 'star': + self.mw_ext.apply_extinction(y, Av=obj.mw_Av) + # erg/s/cm2/A --> photon/s/m2/A all_sed = y * lamb / (cons.h.value * cons.c.value) * 1e-13 sed = Table(np.array([lamb, all_sed]).T, names=('WAVELENGTH', 'FLUX')) diff --git a/config/config_overall.yaml b/config/config_overall.yaml index 8624cc0..5027e49 100644 --- a/config/config_overall.yaml +++ b/config/config_overall.yaml @@ -11,7 +11,7 @@ # can add some of the command-line arguments here as well; # ok to pass either way or both, as long as they are consistent work_dir: "/public/home/fangyuedong/project/workplace/" -run_name: "no_nonlinearity_test" +run_name: "ext_test" # Project cycle and run counter are used to name the outputs project_cycle: 9 @@ -44,7 +44,7 @@ catalog_options: star_only: NO # Only simulate galaxies? - galaxy_only: NO + galaxy_only: YES # rotate galaxy ellipticity rotateEll: 0. # [degree] @@ -65,7 +65,7 @@ obs_setting: # - give a list of indexes of pointings: [ip_1, ip_2...] # - run all pointings: null # Note: only valid when a pointing list is specified - run_pointings: [1] + run_pointings: [0, 1, 2, 3, 4] # Whether to enable astrometric modeling enable_astrometric_model: True diff --git a/config/obs_config_SCI.yaml b/config/obs_config_SCI.yaml index 405950f..ef82bcd 100644 --- a/config/obs_config_SCI.yaml +++ b/config/obs_config_SCI.yaml @@ -16,7 +16,7 @@ obs_id: "00000001" # this setting will only be used if pointing list file is not # Define list of chips # run_chips: [6,7,8,9,11,12,13,14,15,16,17,18,19,20,22,23,24,25] # Photometric chips #run_chips: [1,2,3,4,5,10,21,26,27,28,29,30] # Spectroscopic chips -run_chips: [1] +run_chips: [17, 22] # Define observation sequence call_sequence: diff --git a/observation_sim/mock_objects/ExtinctionMW.py b/observation_sim/mock_objects/ExtinctionMW.py new file mode 100644 index 0000000..a98106a --- /dev/null +++ b/observation_sim/mock_objects/ExtinctionMW.py @@ -0,0 +1,95 @@ +import os +import numpy as np +import healpy as hp +from astropy.io import fits +from astropy import units as u +from astropy.coordinates import SkyCoord + + +class ExtinctionMW(object): + def __init__(self): + self.Rv = 3.1 + self.lamb = np.arange(2000, 11001+0.5, 0.5) + + @staticmethod + def radec2pix(ra, dec, NSIDE=2048): + return hp.pixelfunc.ang2pix(nside=NSIDE, theta=ra, phi=dec, lonlat=True) + + def init_ext_model(self, model_name="odonnell", Av=1.0, Rv=3.1, lamb=None): + self.model_name = model_name + self.Av = Av + self.Rv = Rv + if lamb is not None: + self.lamb = lamb + + if self.model_name == "odonnell": + alpha = np.zeros(self.lamb.shape) + beta = np.zeros(self.lamb.shape) + x = 1.e4 / self.lamb + def f_alpha_1(x): return 0.574 * (x**1.61) + def f_beta_1(x): return -0.527 * (x**1.61) + + def f_alpha_2(x): + y = x - 1.82 + return 1 + 0.104*y - 0.609*(y**2) + 0.701*(y**3) + \ + 1.137*(y**4) - 1.718*(y**5) - 0.827 * \ + (y**6) + 1.647*(y**7) - 0.505*(y**8) + + def f_beta_2(x): + y = x - 1.82 + return 1.952*y + 2.908*(y**2) - 3.989*(y**3) - 7.985 * \ + (y**4) + 11.102*(y**5) + 5.491 * \ + (y**6) - 10.805*(y**7) + 3.347*(y**8) + + def f_alpha_3(x): return 1.752 - 0.316*x - \ + 0.104 / ((x - 4.67)**2 + 0.341) + + def f_beta_3(x): return -3.090 + 1.825*x + \ + 1.206 / ((x - 4.62)**2 + 0.262) + + def f_alpha_4(x): return f_alpha_3(x) + -0.04473 * \ + (x - 5.9)**2 - 0.009779 * (x - 5.9)**3 + + def f_beta_4(x): return f_beta_3(x) + 0.2130 * \ + (x - 5.9)**2 + 0.1207 * (x - 5.9)**3 + + def f_alpha_5(x): return -1.073 - 0.628*(x - 8) + \ + 0.137*(x - 8)**2 - 0.070*(x - 8)**3 + + def f_beta_5(x): return 13.670 + 4.257*(x - 8) - \ + 0.420*(x - 8)**2 + 0.374 * (x - 8)**3 + + alpha = np.piecewise( + x, [x <= 1.1, (x > 1.1)*(x <= 3.3), (x > 3.3)*(x <= 5.9), (x > 5.9)*(x <= 8.), (x > 8.)], [f_alpha_1, f_alpha_2, f_alpha_3, f_alpha_4, f_alpha_5]) + beta = np.piecewise( + x, [x <= 1.1, (x > 1.1)*(x <= 3.3), (x > 3.3)*(x <= 5.9), (x > 5.9)*(x <= 8.), (x > 8.)], [f_beta_1, f_beta_2, f_beta_3, f_beta_4, f_beta_5]) + + self.ext = (alpha + beta / self.Rv) * self.Av + + def load_Planck_ext(self, file_path): + hdu = fits.open(file_path) + self.ebv_planck = hdu[1].data["EBV"] + + def Av_from_Planck(self, ra, dec): + if not hasattr(self, 'ebv_planck'): + raise ValueError( + "Need to load planck dust map first") + # Convert to galactic coordinates + c = SkyCoord(ra=ra * u.degree, dec=dec * + u.degree, frame='icrs').galactic + l, b = c.l.radian, c.b.radian + NSIDE = hp.pixelfunc.get_nside(self.ebv_planck) + pix = hp.pixelfunc.ang2pix(nside=NSIDE, theta=np.pi/2. - b, phi=l) + return self.ebv_planck[pix] * self.Rv + + def apply_extinction(self, spec, Av=1.0): + if len(spec) != len(self.lamb): + raise ValueError( + "Dimension of spec do not match that of ExtinctionMW.lamb: try initilize (init_ext_model) by the actual size of spec which you want to apply the extinction to") + if not hasattr(self, 'ext'): + raise ValueError( + "Need to initialize the extinction model (init_ext_model) first") + scale = 10**(-.4 * self.ext * Av) + print("scale = ", scale) + spec *= scale + return spec diff --git a/observation_sim/mock_objects/__init__.py b/observation_sim/mock_objects/__init__.py index 0a655e1..c6c567f 100755 --- a/observation_sim/mock_objects/__init__.py +++ b/observation_sim/mock_objects/__init__.py @@ -5,3 +5,4 @@ from .Quasar import Quasar from .Star import Star from .Stamp import Stamp from .FlatLED import FlatLED +from .ExtinctionMW import ExtinctionMW diff --git a/submit_jobs.slurm b/submit_jobs.slurm index 34867ae..69d019f 100755 --- a/submit_jobs.slurm +++ b/submit_jobs.slurm @@ -1,10 +1,10 @@ #!/bin/bash #SBATCH -J CSSTSim -#SBATCH -N 1 +#SBATCH -N 2 #SBATCH --ntasks-per-node=6 #SBATCH -p debug -#SBATCH --mem=60G +#SBATCH --mem=96G module load mpi/hpcx/2.4.1/gcc-7.3.1 date @@ -12,4 +12,4 @@ date #限定单节点任务数 srun hostname -s | sort -n | awk -F"-" '{print $2}' | uniq > pnodes -mpirun -mca pml ucx -x UCX_NET_DEVICES=mlx5_0:1 -machinefile pnodes -np 6 --map-by node python3 /public/home/fangyuedong/project/csst_msc_sim/run_sim.py --config_file config_overall.yaml --catalog C9_Catalog -c /public/home/fangyuedong/project/csst_msc_sim/config \ No newline at end of file +mpirun -mca pml ucx -x UCX_NET_DEVICES=mlx5_0:1 -machinefile pnodes -np 12 --map-by node python3 /public/home/fangyuedong/project/csst_msc_sim/run_sim.py --config_file config_overall.yaml --catalog C9_Catalog -c /public/home/fangyuedong/project/csst_msc_sim/config \ No newline at end of file -- GitLab From 1aa4f5339045dae11b99fd09e67aedf9db731741 Mon Sep 17 00:00:00 2001 From: fangyuedong Date: Tue, 23 Jul 2024 08:01:37 +0800 Subject: [PATCH 15/22] 1. add option for galaxy milky way extinction in overall_config 2. bug fix: planck map nested ordering --- catalog/C9_Catalog.py | 21 +++++++++++++------- config/config_overall.yaml | 10 +++++++--- observation_sim/mock_objects/ExtinctionMW.py | 5 +++-- 3 files changed, 24 insertions(+), 12 deletions(-) diff --git a/catalog/C9_Catalog.py b/catalog/C9_Catalog.py index 978d74d..b028bdf 100644 --- a/catalog/C9_Catalog.py +++ b/catalog/C9_Catalog.py @@ -111,10 +111,14 @@ class Catalog(CatalogBase): self.max_size = 0. # [TODO] Milky Way extinction - self.mw_ext = ExtinctionMW() - self.mw_ext.init_ext_model(model_name="odonnell") - self.mw_ext.load_Planck_ext( - file_path="/public/home/fangyuedong/project/ext_maps/planck/HFI_CompMap_ThermalDustModel_2048_R1.20.fits") + if "enable_mw_ext_gal" in config["catalog_options"] and config["catalog_options"]["enable_mw_ext_gal"]: + if "planck_ebv_map" not in config["catalog_options"]: + raise ValueError( + "Planck dust map must be given to enable Milky Way extinction calculation for galaxies.") + self.mw_ext = ExtinctionMW() + self.mw_ext.init_ext_model(model_name="odonnell") + self.mw_ext.load_Planck_ext( + file_path=config["catalog_options"]["planck_ebv_map"]) if "star_cat" in config["catalog_options"]["input_path"] and config["catalog_options"]["input_path"]["star_cat"] and not config["catalog_options"]["galaxy_only"]: # Get the cloest star catalog file @@ -255,7 +259,10 @@ class Catalog(CatalogBase): ) # [TODO] get Milky Way extinction AVs - MW_Av_arr = self.mw_ext.Av_from_Planck(ra=ra_arr, dec=dec_arr) + if "enable_mw_ext_gal" in self.config["catalog_options"] and self.config["catalog_options"]["enable_mw_ext_gal"]: + MW_Av_arr = self.mw_ext.Av_from_Planck(ra=ra_arr, dec=dec_arr) + else: + MW_Av_arr = np.ones(len(ra_arr)) for igals in range(ngals): # # (TEST) @@ -544,8 +551,8 @@ class Catalog(CatalogBase): y = speci(lamb) # [TODO] Apply Milky Way extinction - if obj.type != 'star': - self.mw_ext.apply_extinction(y, Av=obj.mw_Av) + if obj.type != 'star' and ("enable_mw_ext_gal" in self.config["catalog_options"] and self.config["catalog_options"]["enable_mw_ext_gal"]): + y = self.mw_ext.apply_extinction(y, Av=obj.mw_Av) # erg/s/cm2/A --> photon/s/m2/A all_sed = y * lamb / (cons.h.value * cons.c.value) * 1e-13 diff --git a/config/config_overall.yaml b/config/config_overall.yaml index 5027e49..d22dc68 100644 --- a/config/config_overall.yaml +++ b/config/config_overall.yaml @@ -11,7 +11,7 @@ # can add some of the command-line arguments here as well; # ok to pass either way or both, as long as they are consistent work_dir: "/public/home/fangyuedong/project/workplace/" -run_name: "ext_test" +run_name: "ext_on" # Project cycle and run counter are used to name the outputs project_cycle: 9 @@ -44,11 +44,15 @@ catalog_options: star_only: NO # Only simulate galaxies? - galaxy_only: YES + galaxy_only: NO # rotate galaxy ellipticity rotateEll: 0. # [degree] + # Whether to apply milky way extinction to galaxies + enable_mw_ext_gal: YES + planck_ebv_map: "/public/home/fangyuedong/project/ext_maps/planck/HFI_CompMap_ThermalDustModel_2048_R1.20.fits" + ############################################### # Observation setting ############################################### @@ -68,7 +72,7 @@ obs_setting: run_pointings: [0, 1, 2, 3, 4] # Whether to enable astrometric modeling - enable_astrometric_model: True + enable_astrometric_model: YES # Cut by saturation magnitude in which band? cut_in_band: "z" diff --git a/observation_sim/mock_objects/ExtinctionMW.py b/observation_sim/mock_objects/ExtinctionMW.py index a98106a..a754deb 100644 --- a/observation_sim/mock_objects/ExtinctionMW.py +++ b/observation_sim/mock_objects/ExtinctionMW.py @@ -13,7 +13,7 @@ class ExtinctionMW(object): @staticmethod def radec2pix(ra, dec, NSIDE=2048): - return hp.pixelfunc.ang2pix(nside=NSIDE, theta=ra, phi=dec, lonlat=True) + return hp.pixelfunc.ang2pix(nside=NSIDE, theta=ra, phi=dec, nested=True, lonlat=True) def init_ext_model(self, model_name="odonnell", Av=1.0, Rv=3.1, lamb=None): self.model_name = model_name @@ -79,7 +79,8 @@ class ExtinctionMW(object): u.degree, frame='icrs').galactic l, b = c.l.radian, c.b.radian NSIDE = hp.pixelfunc.get_nside(self.ebv_planck) - pix = hp.pixelfunc.ang2pix(nside=NSIDE, theta=np.pi/2. - b, phi=l) + pix = hp.pixelfunc.ang2pix( + nside=NSIDE, theta=np.pi/2. - b, phi=l, nested=True) return self.ebv_planck[pix] * self.Rv def apply_extinction(self, spec, Av=1.0): -- GitLab From 1ba8e79022cfd21d8ba9ce3c5b771adcdc46ed33 Mon Sep 17 00:00:00 2001 From: zhangxin Date: Wed, 24 Jul 2024 15:10:55 +0800 Subject: [PATCH 16/22] fix file name to get_pointing_accuracy.py --- tools/{get_pointing_accurcy.py => get_pointing_accuracy.py} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename tools/{get_pointing_accurcy.py => get_pointing_accuracy.py} (100%) diff --git a/tools/get_pointing_accurcy.py b/tools/get_pointing_accuracy.py similarity index 100% rename from tools/get_pointing_accurcy.py rename to tools/get_pointing_accuracy.py -- GitLab From b8d1624727f2e38f5eee85db01fc80cb241ff0c9 Mon Sep 17 00:00:00 2001 From: fangyuedong Date: Wed, 24 Jul 2024 21:25:02 +0800 Subject: [PATCH 17/22] fix a typo in add_poisson_and_dark --- observation_sim/sim_steps/add_pattern_noise.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/observation_sim/sim_steps/add_pattern_noise.py b/observation_sim/sim_steps/add_pattern_noise.py index dfe90d0..f92cf36 100644 --- a/observation_sim/sim_steps/add_pattern_noise.py +++ b/observation_sim/sim_steps/add_pattern_noise.py @@ -27,7 +27,7 @@ def add_poisson_and_dark(self, chip, filt, tel, pointing, catalog, obs_param): InputDark=None) else: chip.img, _ = chip_utils.add_poisson(img=chip.img, - chip=self, + chip=chip, exptime=exptime, poisson_noise=chip.poisson_noise, dark_noise=0.) -- GitLab From e66531a393106988a678adc7bb945599807e83e2 Mon Sep 17 00:00:00 2001 From: fangyuedong Date: Mon, 29 Jul 2024 06:54:42 +0800 Subject: [PATCH 18/22] bug fix C9_Catalog.py and ExtinctionMW.py --- catalog/C9_Catalog.py | 2 +- observation_sim/mock_objects/ExtinctionMW.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/catalog/C9_Catalog.py b/catalog/C9_Catalog.py index b028bdf..590dda6 100644 --- a/catalog/C9_Catalog.py +++ b/catalog/C9_Catalog.py @@ -262,7 +262,7 @@ class Catalog(CatalogBase): if "enable_mw_ext_gal" in self.config["catalog_options"] and self.config["catalog_options"]["enable_mw_ext_gal"]: MW_Av_arr = self.mw_ext.Av_from_Planck(ra=ra_arr, dec=dec_arr) else: - MW_Av_arr = np.ones(len(ra_arr)) + MW_Av_arr = np.zeros(len(ra_arr)) for igals in range(ngals): # # (TEST) diff --git a/observation_sim/mock_objects/ExtinctionMW.py b/observation_sim/mock_objects/ExtinctionMW.py index a754deb..85ae692 100644 --- a/observation_sim/mock_objects/ExtinctionMW.py +++ b/observation_sim/mock_objects/ExtinctionMW.py @@ -13,7 +13,7 @@ class ExtinctionMW(object): @staticmethod def radec2pix(ra, dec, NSIDE=2048): - return hp.pixelfunc.ang2pix(nside=NSIDE, theta=ra, phi=dec, nested=True, lonlat=True) + return hp.pixelfunc.ang2pix(nside=NSIDE, theta=ra, phi=dec, nest=True, lonlat=True) def init_ext_model(self, model_name="odonnell", Av=1.0, Rv=3.1, lamb=None): self.model_name = model_name @@ -80,7 +80,7 @@ class ExtinctionMW(object): l, b = c.l.radian, c.b.radian NSIDE = hp.pixelfunc.get_nside(self.ebv_planck) pix = hp.pixelfunc.ang2pix( - nside=NSIDE, theta=np.pi/2. - b, phi=l, nested=True) + nside=NSIDE, theta=np.pi/2. - b, phi=l, nest=True) return self.ebv_planck[pix] * self.Rv def apply_extinction(self, spec, Av=1.0): @@ -91,6 +91,6 @@ class ExtinctionMW(object): raise ValueError( "Need to initialize the extinction model (init_ext_model) first") scale = 10**(-.4 * self.ext * Av) - print("scale = ", scale) + # print("scale = ", scale) spec *= scale return spec -- GitLab From 36106f04b9468e914a43550f49dc7bc2f608ede6 Mon Sep 17 00:00:00 2001 From: fangyuedong Date: Tue, 30 Jul 2024 03:15:54 +0800 Subject: [PATCH 19/22] change bluest and reddest end points (to 2000 and 11000 respectively) for sub bandpasses. --- observation_sim/instruments/data/filters/fgs_sub.list | 2 +- observation_sim/instruments/data/filters/g_sub.list | 4 ++-- observation_sim/instruments/data/filters/i_sub.list | 4 ++-- observation_sim/instruments/data/filters/nuv_sub.list | 4 ++-- observation_sim/instruments/data/filters/r_sub.list | 4 ++-- observation_sim/instruments/data/filters/u_sub.list | 4 ++-- observation_sim/instruments/data/filters/y_sub.list | 4 ++-- observation_sim/instruments/data/filters/z_sub.list | 4 ++-- 8 files changed, 15 insertions(+), 15 deletions(-) diff --git a/observation_sim/instruments/data/filters/fgs_sub.list b/observation_sim/instruments/data/filters/fgs_sub.list index 5a826ee..c02a44f 100644 --- a/observation_sim/instruments/data/filters/fgs_sub.list +++ b/observation_sim/instruments/data/filters/fgs_sub.list @@ -1,4 +1,4 @@ -3000 +2000 4500 4750 5000 diff --git a/observation_sim/instruments/data/filters/g_sub.list b/observation_sim/instruments/data/filters/g_sub.list index f5dda57..1384ade 100644 --- a/observation_sim/instruments/data/filters/g_sub.list +++ b/observation_sim/instruments/data/filters/g_sub.list @@ -1,4 +1,4 @@ -3800 +2000 4217 4432 4631 @@ -6,4 +6,4 @@ 5002 5179 5354 -5799 \ No newline at end of file +11000 \ No newline at end of file diff --git a/observation_sim/instruments/data/filters/i_sub.list b/observation_sim/instruments/data/filters/i_sub.list index 715f74a..0449403 100644 --- a/observation_sim/instruments/data/filters/i_sub.list +++ b/observation_sim/instruments/data/filters/i_sub.list @@ -1,4 +1,4 @@ -6600 +2000 7061 7255 7448 @@ -6,4 +6,4 @@ 7833 8027 8226 -8999 \ No newline at end of file +11000 \ No newline at end of file diff --git a/observation_sim/instruments/data/filters/nuv_sub.list b/observation_sim/instruments/data/filters/nuv_sub.list index c89b5dc..b6c60c5 100644 --- a/observation_sim/instruments/data/filters/nuv_sub.list +++ b/observation_sim/instruments/data/filters/nuv_sub.list @@ -1,4 +1,4 @@ -2513 +2000 2621 2716 2805 @@ -6,4 +6,4 @@ 2969 3050 3132 -3499 \ No newline at end of file +11000 \ No newline at end of file diff --git a/observation_sim/instruments/data/filters/r_sub.list b/observation_sim/instruments/data/filters/r_sub.list index 0abf191..ec0852e 100644 --- a/observation_sim/instruments/data/filters/r_sub.list +++ b/observation_sim/instruments/data/filters/r_sub.list @@ -1,4 +1,4 @@ -5100 +2000 5642 5821 6001 @@ -6,4 +6,4 @@ 6363 6547 6735 -7199 \ No newline at end of file +11000 \ No newline at end of file diff --git a/observation_sim/instruments/data/filters/u_sub.list b/observation_sim/instruments/data/filters/u_sub.list index f3a2b72..3ec5a58 100644 --- a/observation_sim/instruments/data/filters/u_sub.list +++ b/observation_sim/instruments/data/filters/u_sub.list @@ -1,4 +1,4 @@ -3000 +2000 3277 3380 3485 @@ -6,4 +6,4 @@ 3703 3813 3918 -4499 \ No newline at end of file +11000 \ No newline at end of file diff --git a/observation_sim/instruments/data/filters/y_sub.list b/observation_sim/instruments/data/filters/y_sub.list index 81dc243..69a05ee 100644 --- a/observation_sim/instruments/data/filters/y_sub.list +++ b/observation_sim/instruments/data/filters/y_sub.list @@ -1,4 +1,4 @@ -9000 +2000 9322 9405 9489 @@ -6,4 +6,4 @@ 9695 9832 10024 -10590 \ No newline at end of file +11000 \ No newline at end of file diff --git a/observation_sim/instruments/data/filters/z_sub.list b/observation_sim/instruments/data/filters/z_sub.list index b0191a5..f105711 100644 --- a/observation_sim/instruments/data/filters/z_sub.list +++ b/observation_sim/instruments/data/filters/z_sub.list @@ -1,4 +1,4 @@ -7800 +2000 8494 8638 8790 @@ -6,4 +6,4 @@ 9141 9363 9663 -10590 \ No newline at end of file +11000 \ No newline at end of file -- GitLab From dfb71c23e1d3a99f280f5393b675daee4903d3ba Mon Sep 17 00:00:00 2001 From: fangyuedong Date: Tue, 30 Jul 2024 20:06:33 +0800 Subject: [PATCH 20/22] magnitude ('mag_use_normal') calculations for galaxies and QSOs now is only based on their SEDs --- catalog/C9_Catalog.py | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/catalog/C9_Catalog.py b/catalog/C9_Catalog.py index 590dda6..146205d 100644 --- a/catalog/C9_Catalog.py +++ b/catalog/C9_Catalog.py @@ -557,8 +557,22 @@ class Catalog(CatalogBase): # erg/s/cm2/A --> photon/s/m2/A all_sed = y * lamb / (cons.h.value * cons.c.value) * 1e-13 sed = Table(np.array([lamb, all_sed]).T, names=('WAVELENGTH', 'FLUX')) - if obj.type == 'quasar': - # integrate to get the magnitudes + # if obj.type == 'quasar': + # # integrate to get the magnitudes + # sed_photon = np.array([sed['WAVELENGTH'], sed['FLUX']]).T + # sed_photon = galsim.LookupTable(x=np.array(sed_photon[:, 0]), f=np.array( + # sed_photon[:, 1]), interpolant='nearest') + # sed_photon = galsim.SED( + # sed_photon, wave_type='A', flux_type='1', fast=False) + # interFlux = integrate_sed_bandpass( + # sed=sed_photon, bandpass=self.filt.bandpass_full) + # obj.param['mag_use_normal'] = getABMAG( + # interFlux, self.filt.bandpass_full) + # # mag = getABMAG(interFlux, self.filt.bandpass_full) + # # print("mag diff = %.3f"%(mag - obj.param['mag_use_normal'])) + + # integrate to get the magnitudes + if obj.type == 'quasar' or obj.type == 'galaxy': sed_photon = np.array([sed['WAVELENGTH'], sed['FLUX']]).T sed_photon = galsim.LookupTable(x=np.array(sed_photon[:, 0]), f=np.array( sed_photon[:, 1]), interpolant='nearest') -- GitLab From b9723717902e49a0615a6c7f7048da81ae8454bb Mon Sep 17 00:00:00 2001 From: Fang Yuedong Date: Tue, 30 Jul 2024 15:23:01 +0000 Subject: [PATCH 21/22] Add Milky Way extinction and extend the range for SED integration --- catalog/C9_Catalog.py | 39 ++++++++++++++----- config/config_overall.yaml | 10 +++-- .../instruments/data/filters/fgs_sub.list | 2 +- .../instruments/data/filters/g_sub.list | 4 +- .../instruments/data/filters/i_sub.list | 4 +- .../instruments/data/filters/nuv_sub.list | 4 +- .../instruments/data/filters/r_sub.list | 4 +- .../instruments/data/filters/u_sub.list | 4 +- .../instruments/data/filters/y_sub.list | 4 +- .../instruments/data/filters/z_sub.list | 4 +- observation_sim/mock_objects/ExtinctionMW.py | 7 ++-- .../sim_steps/add_pattern_noise.py | 2 +- 12 files changed, 57 insertions(+), 31 deletions(-) diff --git a/catalog/C9_Catalog.py b/catalog/C9_Catalog.py index 978d74d..146205d 100644 --- a/catalog/C9_Catalog.py +++ b/catalog/C9_Catalog.py @@ -111,10 +111,14 @@ class Catalog(CatalogBase): self.max_size = 0. # [TODO] Milky Way extinction - self.mw_ext = ExtinctionMW() - self.mw_ext.init_ext_model(model_name="odonnell") - self.mw_ext.load_Planck_ext( - file_path="/public/home/fangyuedong/project/ext_maps/planck/HFI_CompMap_ThermalDustModel_2048_R1.20.fits") + if "enable_mw_ext_gal" in config["catalog_options"] and config["catalog_options"]["enable_mw_ext_gal"]: + if "planck_ebv_map" not in config["catalog_options"]: + raise ValueError( + "Planck dust map must be given to enable Milky Way extinction calculation for galaxies.") + self.mw_ext = ExtinctionMW() + self.mw_ext.init_ext_model(model_name="odonnell") + self.mw_ext.load_Planck_ext( + file_path=config["catalog_options"]["planck_ebv_map"]) if "star_cat" in config["catalog_options"]["input_path"] and config["catalog_options"]["input_path"]["star_cat"] and not config["catalog_options"]["galaxy_only"]: # Get the cloest star catalog file @@ -255,7 +259,10 @@ class Catalog(CatalogBase): ) # [TODO] get Milky Way extinction AVs - MW_Av_arr = self.mw_ext.Av_from_Planck(ra=ra_arr, dec=dec_arr) + if "enable_mw_ext_gal" in self.config["catalog_options"] and self.config["catalog_options"]["enable_mw_ext_gal"]: + MW_Av_arr = self.mw_ext.Av_from_Planck(ra=ra_arr, dec=dec_arr) + else: + MW_Av_arr = np.zeros(len(ra_arr)) for igals in range(ngals): # # (TEST) @@ -544,14 +551,28 @@ class Catalog(CatalogBase): y = speci(lamb) # [TODO] Apply Milky Way extinction - if obj.type != 'star': - self.mw_ext.apply_extinction(y, Av=obj.mw_Av) + if obj.type != 'star' and ("enable_mw_ext_gal" in self.config["catalog_options"] and self.config["catalog_options"]["enable_mw_ext_gal"]): + y = self.mw_ext.apply_extinction(y, Av=obj.mw_Av) # erg/s/cm2/A --> photon/s/m2/A all_sed = y * lamb / (cons.h.value * cons.c.value) * 1e-13 sed = Table(np.array([lamb, all_sed]).T, names=('WAVELENGTH', 'FLUX')) - if obj.type == 'quasar': - # integrate to get the magnitudes + # if obj.type == 'quasar': + # # integrate to get the magnitudes + # sed_photon = np.array([sed['WAVELENGTH'], sed['FLUX']]).T + # sed_photon = galsim.LookupTable(x=np.array(sed_photon[:, 0]), f=np.array( + # sed_photon[:, 1]), interpolant='nearest') + # sed_photon = galsim.SED( + # sed_photon, wave_type='A', flux_type='1', fast=False) + # interFlux = integrate_sed_bandpass( + # sed=sed_photon, bandpass=self.filt.bandpass_full) + # obj.param['mag_use_normal'] = getABMAG( + # interFlux, self.filt.bandpass_full) + # # mag = getABMAG(interFlux, self.filt.bandpass_full) + # # print("mag diff = %.3f"%(mag - obj.param['mag_use_normal'])) + + # integrate to get the magnitudes + if obj.type == 'quasar' or obj.type == 'galaxy': sed_photon = np.array([sed['WAVELENGTH'], sed['FLUX']]).T sed_photon = galsim.LookupTable(x=np.array(sed_photon[:, 0]), f=np.array( sed_photon[:, 1]), interpolant='nearest') diff --git a/config/config_overall.yaml b/config/config_overall.yaml index 5027e49..d22dc68 100644 --- a/config/config_overall.yaml +++ b/config/config_overall.yaml @@ -11,7 +11,7 @@ # can add some of the command-line arguments here as well; # ok to pass either way or both, as long as they are consistent work_dir: "/public/home/fangyuedong/project/workplace/" -run_name: "ext_test" +run_name: "ext_on" # Project cycle and run counter are used to name the outputs project_cycle: 9 @@ -44,11 +44,15 @@ catalog_options: star_only: NO # Only simulate galaxies? - galaxy_only: YES + galaxy_only: NO # rotate galaxy ellipticity rotateEll: 0. # [degree] + # Whether to apply milky way extinction to galaxies + enable_mw_ext_gal: YES + planck_ebv_map: "/public/home/fangyuedong/project/ext_maps/planck/HFI_CompMap_ThermalDustModel_2048_R1.20.fits" + ############################################### # Observation setting ############################################### @@ -68,7 +72,7 @@ obs_setting: run_pointings: [0, 1, 2, 3, 4] # Whether to enable astrometric modeling - enable_astrometric_model: True + enable_astrometric_model: YES # Cut by saturation magnitude in which band? cut_in_band: "z" diff --git a/observation_sim/instruments/data/filters/fgs_sub.list b/observation_sim/instruments/data/filters/fgs_sub.list index 5a826ee..c02a44f 100644 --- a/observation_sim/instruments/data/filters/fgs_sub.list +++ b/observation_sim/instruments/data/filters/fgs_sub.list @@ -1,4 +1,4 @@ -3000 +2000 4500 4750 5000 diff --git a/observation_sim/instruments/data/filters/g_sub.list b/observation_sim/instruments/data/filters/g_sub.list index f5dda57..1384ade 100644 --- a/observation_sim/instruments/data/filters/g_sub.list +++ b/observation_sim/instruments/data/filters/g_sub.list @@ -1,4 +1,4 @@ -3800 +2000 4217 4432 4631 @@ -6,4 +6,4 @@ 5002 5179 5354 -5799 \ No newline at end of file +11000 \ No newline at end of file diff --git a/observation_sim/instruments/data/filters/i_sub.list b/observation_sim/instruments/data/filters/i_sub.list index 715f74a..0449403 100644 --- a/observation_sim/instruments/data/filters/i_sub.list +++ b/observation_sim/instruments/data/filters/i_sub.list @@ -1,4 +1,4 @@ -6600 +2000 7061 7255 7448 @@ -6,4 +6,4 @@ 7833 8027 8226 -8999 \ No newline at end of file +11000 \ No newline at end of file diff --git a/observation_sim/instruments/data/filters/nuv_sub.list b/observation_sim/instruments/data/filters/nuv_sub.list index c89b5dc..b6c60c5 100644 --- a/observation_sim/instruments/data/filters/nuv_sub.list +++ b/observation_sim/instruments/data/filters/nuv_sub.list @@ -1,4 +1,4 @@ -2513 +2000 2621 2716 2805 @@ -6,4 +6,4 @@ 2969 3050 3132 -3499 \ No newline at end of file +11000 \ No newline at end of file diff --git a/observation_sim/instruments/data/filters/r_sub.list b/observation_sim/instruments/data/filters/r_sub.list index 0abf191..ec0852e 100644 --- a/observation_sim/instruments/data/filters/r_sub.list +++ b/observation_sim/instruments/data/filters/r_sub.list @@ -1,4 +1,4 @@ -5100 +2000 5642 5821 6001 @@ -6,4 +6,4 @@ 6363 6547 6735 -7199 \ No newline at end of file +11000 \ No newline at end of file diff --git a/observation_sim/instruments/data/filters/u_sub.list b/observation_sim/instruments/data/filters/u_sub.list index f3a2b72..3ec5a58 100644 --- a/observation_sim/instruments/data/filters/u_sub.list +++ b/observation_sim/instruments/data/filters/u_sub.list @@ -1,4 +1,4 @@ -3000 +2000 3277 3380 3485 @@ -6,4 +6,4 @@ 3703 3813 3918 -4499 \ No newline at end of file +11000 \ No newline at end of file diff --git a/observation_sim/instruments/data/filters/y_sub.list b/observation_sim/instruments/data/filters/y_sub.list index 81dc243..69a05ee 100644 --- a/observation_sim/instruments/data/filters/y_sub.list +++ b/observation_sim/instruments/data/filters/y_sub.list @@ -1,4 +1,4 @@ -9000 +2000 9322 9405 9489 @@ -6,4 +6,4 @@ 9695 9832 10024 -10590 \ No newline at end of file +11000 \ No newline at end of file diff --git a/observation_sim/instruments/data/filters/z_sub.list b/observation_sim/instruments/data/filters/z_sub.list index b0191a5..f105711 100644 --- a/observation_sim/instruments/data/filters/z_sub.list +++ b/observation_sim/instruments/data/filters/z_sub.list @@ -1,4 +1,4 @@ -7800 +2000 8494 8638 8790 @@ -6,4 +6,4 @@ 9141 9363 9663 -10590 \ No newline at end of file +11000 \ No newline at end of file diff --git a/observation_sim/mock_objects/ExtinctionMW.py b/observation_sim/mock_objects/ExtinctionMW.py index a98106a..85ae692 100644 --- a/observation_sim/mock_objects/ExtinctionMW.py +++ b/observation_sim/mock_objects/ExtinctionMW.py @@ -13,7 +13,7 @@ class ExtinctionMW(object): @staticmethod def radec2pix(ra, dec, NSIDE=2048): - return hp.pixelfunc.ang2pix(nside=NSIDE, theta=ra, phi=dec, lonlat=True) + return hp.pixelfunc.ang2pix(nside=NSIDE, theta=ra, phi=dec, nest=True, lonlat=True) def init_ext_model(self, model_name="odonnell", Av=1.0, Rv=3.1, lamb=None): self.model_name = model_name @@ -79,7 +79,8 @@ class ExtinctionMW(object): u.degree, frame='icrs').galactic l, b = c.l.radian, c.b.radian NSIDE = hp.pixelfunc.get_nside(self.ebv_planck) - pix = hp.pixelfunc.ang2pix(nside=NSIDE, theta=np.pi/2. - b, phi=l) + pix = hp.pixelfunc.ang2pix( + nside=NSIDE, theta=np.pi/2. - b, phi=l, nest=True) return self.ebv_planck[pix] * self.Rv def apply_extinction(self, spec, Av=1.0): @@ -90,6 +91,6 @@ class ExtinctionMW(object): raise ValueError( "Need to initialize the extinction model (init_ext_model) first") scale = 10**(-.4 * self.ext * Av) - print("scale = ", scale) + # print("scale = ", scale) spec *= scale return spec diff --git a/observation_sim/sim_steps/add_pattern_noise.py b/observation_sim/sim_steps/add_pattern_noise.py index dfe90d0..f92cf36 100644 --- a/observation_sim/sim_steps/add_pattern_noise.py +++ b/observation_sim/sim_steps/add_pattern_noise.py @@ -27,7 +27,7 @@ def add_poisson_and_dark(self, chip, filt, tel, pointing, catalog, obs_param): InputDark=None) else: chip.img, _ = chip_utils.add_poisson(img=chip.img, - chip=self, + chip=chip, exptime=exptime, poisson_noise=chip.poisson_noise, dark_noise=0.) -- GitLab From 615e951fbdd9dafa6fbfb564588d7fda26498381 Mon Sep 17 00:00:00 2001 From: fangyuedong Date: Thu, 1 Aug 2024 09:46:23 +0800 Subject: [PATCH 22/22] bug fix for guidance abberation correction --- observation_sim/ObservationSim.py | 26 +++++++++++++----------- observation_sim/config/ChipOutput.py | 4 ++-- observation_sim/sim_steps/add_objects.py | 5 +++-- 3 files changed, 19 insertions(+), 16 deletions(-) diff --git a/observation_sim/ObservationSim.py b/observation_sim/ObservationSim.py index 4fa42d4..cb060ab 100755 --- a/observation_sim/ObservationSim.py +++ b/observation_sim/ObservationSim.py @@ -23,7 +23,7 @@ class Observation(object): self.filter_param = FilterParam() self.Catalog = Catalog - def prepare_chip_for_exposure(self, chip, ra_cen, dec_cen, pointing, wcs_fp=None, slsPSFOptim = False): + def prepare_chip_for_exposure(self, chip, ra_cen, dec_cen, pointing, wcs_fp=None, slsPSFOptim=False): # Get WCS for the focal plane if wcs_fp == None: wcs_fp = self.focal_plane.getTanWCS( @@ -35,21 +35,22 @@ class Observation(object): chip.img.wcs = wcs_fp chip.slsPSFOptim = slsPSFOptim - if chip.chipID in [1,2,3,4,5,10,21,26,27,28,29,30] and slsPSFOptim: + if chip.chipID in [1, 2, 3, 4, 5, 10, 21, 26, 27, 28, 29, 30] and slsPSFOptim: chip.img_stack = {} for id1 in np.arange(2): gn = chip_utils.getChipSLSGratingID(chip.chipID)[id1] orders = {} # for id2 in ['-2','-1','0','1','2']: - for id2 in ['0','1']: + for id2 in ['0', '1']: o_n = "order"+id2 allbands = {} - for id3 in ['1','2','3','4']: + for id3 in ['1', '2', '3', '4']: w_n = "w"+id3 allbands[w_n] = galsim.ImageF(chip.npix_x, chip.npix_y) - allbands[w_n].setOrigin(chip.bound.xmin, chip.bound.ymin) + allbands[w_n].setOrigin( + chip.bound.xmin, chip.bound.ymin) allbands[w_n].wcs = wcs_fp - orders[o_n] = allbands + orders[o_n] = allbands chip.img_stack[gn] = orders else: chip.img_stack = {} @@ -111,16 +112,17 @@ class Observation(object): input_date_str=date_str, input_time_str=time_str ) - ra_cen, dec_cen = ra_cen[0], dec_cen[0] - ra_offset, dec_offset = pointing.ra - ra_cen, pointing.dec - dec_cen + ra_offset, dec_offset = pointing.ra - \ + ra_cen[0], pointing.dec - dec_cen[0] else: - ra_cen = pointing.ra - dec_cen = pointing.dec ra_offset, dec_offset = 0., 0. - + ra_cen = pointing.ra + dec_cen = pointing.dec + slsPSFOpt = False # Prepare necessary chip properties for simulation - chip = self.prepare_chip_for_exposure(chip, ra_cen, dec_cen, pointing, slsPSFOptim = slsPSFOpt) + chip = self.prepare_chip_for_exposure( + chip, ra_cen, dec_cen, pointing, slsPSFOptim=slsPSFOpt) # Initialize SimSteps sim_steps = SimSteps(overall_config=self.config, diff --git a/observation_sim/config/ChipOutput.py b/observation_sim/config/ChipOutput.py index 5efd061..7db5e12 100755 --- a/observation_sim/config/ChipOutput.py +++ b/observation_sim/config/ChipOutput.py @@ -78,12 +78,12 @@ class ChipOutput(object): self.hdr += "\n" self.cat.write(self.hdr) - def cat_add_obj(self, obj, pos_img, pos_shear): + def cat_add_obj(self, obj, pos_img, pos_shear, ra_offset=0., dec_offset=0.): ximg = obj.real_pos.x + 1.0 yimg = obj.real_pos.y + 1.0 line = self.fmt % ( - obj.id, int(self.chip_label), self.filt.filter_type, ximg, yimg, obj.ra, obj.dec, obj.ra_orig, obj.dec_orig, obj.z, obj.getMagFilter( + obj.id, int(self.chip_label), self.filt.filter_type, ximg, yimg, obj.ra + ra_offset, obj.dec + dec_offset, obj.ra_orig, obj.dec_orig, obj.z, obj.getMagFilter( self.filt), obj.type, obj.pmra, obj.pmdec, obj.rv, obj.parallax) line += obj.additional_output_str diff --git a/observation_sim/sim_steps/add_objects.py b/observation_sim/sim_steps/add_objects.py index 9ce6c0a..6c9c7c1 100644 --- a/observation_sim/sim_steps/add_objects.py +++ b/observation_sim/sim_steps/add_objects.py @@ -194,7 +194,8 @@ def add_objects(self, chip, filt, tel, pointing, catalog, obs_param): if isUpdated == 1: # TODO: add up stats - self.chip_output.cat_add_obj(obj, pos_img, pos_shear) + self.chip_output.cat_add_obj( + obj, pos_img, pos_shear, ra_offset=self.ra_offset, dec_offset=self.dec_offset) pass elif isUpdated == 0: missed_obj += 1 @@ -236,7 +237,7 @@ def add_objects(self, chip, filt, tel, pointing, catalog, obs_param): # fits.writeto('order0.fits',img1[0],overwrite=True) # fits.writeto('order1.fits',img1[1],overwrite=True) - psf_model.convolveFullImgWithPCAPSF(chip) + psf_model.convolveFullImgWithPCAPSF(chip) del psf_model gc.collect() -- GitLab